Added method to IsolateVisitor to check for special isolates (i.e., service / vm isolates) since th…

Added method to IsolateVisitor to check for special isolates (i.e., service / vm isolates) since this check is done frequently.

BUG=
R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/7eef11a0e8e10583124532502bb1394252acb19b

[bkonyi, 2016-12-12 22:46:10]

bkonyi@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-12-12 22:47:26]

https://codereview.chromium.org/2567193002/diff/1/runtime/vm/isolate.h
File runtime/vm/isolate.h (right):

https://codereview.chromium.org/2567193002/diff/1/runtime/vm/isolate.h#newcode96
runtime/vm/isolate.h:96: bool IsSpecialIsolate(Isolate* isolate) const;
Let's name it something like:

IsVMInternalIsolate

comment:

// Returns true if |isolate| is the VM isolate or a service isolate.

[bkonyi, 2016-12-12 22:51:20]

https://codereview.chromium.org/2567193002/diff/1/runtime/vm/isolate.h
File runtime/vm/isolate.h (right):

https://codereview.chromium.org/2567193002/diff/1/runtime/vm/isolate.h#newcode96
runtime/vm/isolate.h:96: bool IsSpecialIsolate(Isolate* isolate) const;
On 2016/12/12 22:47:26, Cutch wrote:
> Let's name it something like:
> 
> IsVMInternalIsolate
> 
> comment:
> 
> // Returns true if |isolate| is the VM isolate or a service isolate.

Done.

[rmacnak, 2016-12-12 22:51:38]

rmacnak@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-12-12 22:51:38]

https://codereview.chromium.org/2567193002/diff/1/runtime/vm/isolate.h
File runtime/vm/isolate.h (right):

https://codereview.chromium.org/2567193002/diff/1/runtime/vm/isolate.h#newcode96
runtime/vm/isolate.h:96: bool IsSpecialIsolate(Isolate* isolate) const;
On 2016/12/12 22:47:26, Cutch wrote:
> Let's name it something like:
> 
> IsVMInternalIsolate
> 
> comment:
> 
> // Returns true if |isolate| is the VM isolate or a service isolate.

Probably the kernel isolate too.

[Cutch, 2016-12-12 22:52:48]

On 2016/12/12 22:51:38, rmacnak wrote:
> https://codereview.chromium.org/2567193002/diff/1/runtime/vm/isolate.h
> File runtime/vm/isolate.h (right):
> 
>
https://codereview.chromium.org/2567193002/diff/1/runtime/vm/isolate.h#newcode96
> runtime/vm/isolate.h:96: bool IsSpecialIsolate(Isolate* isolate) const;
> On 2016/12/12 22:47:26, Cutch wrote:
> > Let's name it something like:
> > 
> > IsVMInternalIsolate
> > 
> > comment:
> > 
> > // Returns true if |isolate| is the VM isolate or a service isolate.
> 
> Probably the kernel isolate too.

I'm imagining "service" capturing all internal isolates.

[Cutch, 2016-12-12 22:52:56]

lgtm

[bkonyi, 2016-12-12 22:54:13]

Description was changed from

==========
Added method to IsolateVisitor to check for special isolates (i.e., service / vm
isolates) since this check is done frequently.

BUG=
==========

to

==========
Added method to IsolateVisitor to check for special isolates (i.e., service / vm
isolates) since this check is done frequently.

BUG=
R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7eef11a0e8e10583124532502bb1394252acb19b
==========

[bkonyi, 2016-12-12 22:54:14]

Committed patchset #2 (id:20001) manually as
7eef11a0e8e10583124532502bb1394252acb19b (presubmit successful).