Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2567153002: Updated SimpleManyTasksWithZones test to not use PrintJSONForVM (Closed)

Created:
4 years ago by bkonyi
Modified:
4 years ago
Reviewers:
zra, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Updated SimpleManyTasksWithZones test to not use PrintJSONForVM Fixed test to not use PrintJSONForVM to get isolate information since it only returns @Isolates. Also removed some unnecessary comments and checks for isolate ids. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/0d16859d87dc22c85eebebcdd9edbdbc4a831b74

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed test to not use PrintJSONForVM to get isolate information since it only returns @Isolates. Al… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -17 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/thread_test.cc View 1 2 chunks +4 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bkonyi
4 years ago (2016-12-12 21:26:54 UTC) #2
Cutch
https://codereview.chromium.org/2567153002/diff/1/runtime/vm/thread_test.cc File runtime/vm/thread_test.cc (right): https://codereview.chromium.org/2567153002/diff/1/runtime/vm/thread_test.cc#newcode322 runtime/vm/thread_test.cc:322: arr.AddValue(isolate, false); Just call it directly: isolate->PrintJSON(&stream, false);
4 years ago (2016-12-12 21:28:42 UTC) #3
bkonyi
https://codereview.chromium.org/2567153002/diff/1/runtime/vm/thread_test.cc File runtime/vm/thread_test.cc (right): https://codereview.chromium.org/2567153002/diff/1/runtime/vm/thread_test.cc#newcode322 runtime/vm/thread_test.cc:322: arr.AddValue(isolate, false); On 2016/12/12 21:28:42, Cutch wrote: > Just ...
4 years ago (2016-12-12 21:33:23 UTC) #4
Cutch
lgtm
4 years ago (2016-12-12 21:34:40 UTC) #5
bkonyi
4 years ago (2016-12-12 21:35:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0d16859d87dc22c85eebebcdd9edbdbc4a831b74 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698