Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: media/base/silent_sink_suspender_unittest.cc

Issue 2567143002: media::SilentSinkSuspender should simulate |delay| and |delay_timestamp| (Closed)
Patch Set: build fix content_unittets & media_blink_unittsests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/silent_sink_suspender.cc ('k') | media/blink/webaudiosourceprovider_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/silent_sink_suspender_unittest.cc
diff --git a/media/base/silent_sink_suspender_unittest.cc b/media/base/silent_sink_suspender_unittest.cc
index 4434d69d658f763f7a8b9944ae9de7b9bbef27e7..81770d233aa14cc676ab5d211939763d019348dc 100644
--- a/media/base/silent_sink_suspender_unittest.cc
+++ b/media/base/silent_sink_suspender_unittest.cc
@@ -25,7 +25,7 @@ class SilentSinkSuspenderTest : public testing::Test {
8,
128),
mock_sink_(new testing::StrictMock<MockAudioRendererSink>()),
- fake_callback_(0.1),
+ fake_callback_(0.1, params_.sample_rate()),
temp_bus_(AudioBus::Create(params_)),
// Set a negative timeout so any silence will suspend immediately.
suspender_(&fake_callback_,
@@ -49,9 +49,12 @@ class SilentSinkSuspenderTest : public testing::Test {
TEST_F(SilentSinkSuspenderTest, BasicPassthough) {
temp_bus_->Zero();
+ auto delay = base::TimeDelta::FromMilliseconds(20);
EXPECT_EQ(temp_bus_->frames(),
- suspender_.Render(base::TimeDelta(), base::TimeTicks(), 0,
- temp_bus_.get()));
+ suspender_.Render(delay, base::TimeTicks(), 0, temp_bus_.get()));
+
+ // Delay should remain.
+ EXPECT_EQ(delay, fake_callback_.last_delay());
EXPECT_FALSE(temp_bus_->AreFramesZero());
}
« no previous file with comments | « media/base/silent_sink_suspender.cc ('k') | media/blink/webaudiosourceprovider_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698