Remove 'transport' paths from PassThroughImageTransportSurface

content/common/gpu/image_transport_surface_android.cc

Index: content/common/gpu/image_transport_surface_android.cc
diff --git a/content/common/gpu/image_transport_surface_android.cc b/content/common/gpu/image_transport_surface_android.cc
index c5ea3b3b44f726ed462e83e0b9e6ce6588cfc91f..ba3a12d2e53be16616f14669f9867c94b5436e51 100644
--- a/content/common/gpu/image_transport_surface_android.cc
+++ b/content/common/gpu/image_transport_surface_android.cc
@@ -60,8 +60,7 @@ class DirectSurfaceAndroid : public PassThroughImageTransportSurface {
  public:
   DirectSurfaceAndroid(GpuChannelManager* manager,
                        GpuCommandBufferStub* stub,
-                       gfx::GLSurface* surface,
-                       bool transport);
+                       gfx::GLSurface* surface);
 
   // gfx::GLSurface implementation.
   virtual bool SwapBuffers() OVERRIDE;
@@ -78,7 +77,7 @@ ImageTransportSurfaceAndroid::ImageTransportSurfaceAndroid(
     GpuCommandBufferStub* stub,
     gfx::GLSurface* surface,
     uint32 parent_client_id)
-    : PassThroughImageTransportSurface(manager, stub, surface, true),

[piman, 2014/04/25 05:41:14]

This is the only one that was setting it to true.
However, it's been a long time since SwapBuffers, etc. were going through the
"transport" path (e.g. SwapBuffers is actually marked NOTREACHED), so I think
it's ok to assume it could just as well be false.

Let me know if I'm missing something here.

[no sievers, 2014/04/25 17:51:00]

Should be fine. We don't expect glSwapBuffers() or glResizeCHROMIUM() here with
Ubercomp (or previously MailboxOutputSurface), which is the code which you are
removing. It wouldn't even have worked for resize, since we'd have stayed
descheduled and never gotten an ack from the browser.

+    : PassThroughImageTransportSurface(manager, stub, surface),
       parent_client_id_(parent_client_id) {}
 
 ImageTransportSurfaceAndroid::~ImageTransportSurfaceAndroid() {}
@@ -148,9 +147,8 @@ void ImageTransportSurfaceAndroid::DoWakeUpGpu() {
 
 DirectSurfaceAndroid::DirectSurfaceAndroid(GpuChannelManager* manager,
                                            GpuCommandBufferStub* stub,
-                                           gfx::GLSurface* surface,
-                                           bool transport)
-    : PassThroughImageTransportSurface(manager, stub, surface, transport) {}
+                                           gfx::GLSurface* surface)
+    : PassThroughImageTransportSurface(manager, stub, surface) {}
 
 DirectSurfaceAndroid::~DirectSurfaceAndroid() {}
 
@@ -188,7 +186,7 @@ scoped_refptr<gfx::GLSurface> ImageTransportSurface::CreateNativeSurface(
     return scoped_refptr<gfx::GLSurface>();
 
   return scoped_refptr<gfx::GLSurface>(
-      new DirectSurfaceAndroid(manager, stub, surface.get(), false));
+      new DirectSurfaceAndroid(manager, stub, surface.get()));
 }
 
 }  // namespace content