Issue 2567113003: Send errors notification without delay.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2567113003: Send errors notification without delay. (Closed)

Created:
4 years ago by scheglov

Modified:
4 years ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Send errors notification without delay. Update 'analysis.updateContent' integration test. This might be OK from performance POV - errors are cheaper to send than for example navigation. And this satisfies the goal of 'analyzing' notification - that new errors are to be expected. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d564b0aaab3c5dc6871721057f85eb07d294e700

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -52 lines)			Patch
	M	pkg/analysis_server/lib/src/analysis_server.dart	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	pkg/analysis_server/test/integration/analysis/update_content_test.dart	View		2 chunks	+36 lines, -49 lines	0 comments	Download

Total messages: 4 (1 generated)

Brian Wilkerson

Is this performant if the errors have not yet been computed? If so, lgtm.

4 years ago (2016-12-12 19:31:52 UTC) #2

scheglov

4 years ago (2016-12-12 19:39:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d564b0aaab3c5dc6871721057f85eb07d294e700 (presubmit successful).