[cronet] Add a Builder class for UrlRequestContextConfig

components/cronet/ios/cronet_environment.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/cronet/ios/cronet_environment.h"
 
 #include <utility>
 
 #include "base/at_exit.h"
 #include "base/atomicops.h"
@@ skipping 252 matching lines @@
 
   if (user_agent_partial_)
     user_agent_ = web::BuildUserAgentFromProduct(user_agent_);
 
   // Cache
   base::FilePath cache_path;
   if (!PathService::Get(base::DIR_CACHE, &cache_path))
     return;
   cache_path = cache_path.Append(FILE_PATH_LITERAL("cronet"));
 
-  std::unique_ptr<URLRequestContextConfig> config(new URLRequestContextConfig(
-      quic_enabled_,  // Enable QUIC.
-      quic_enabled_ && quic_user_agent_id_.empty()
-          ? getDefaultQuicUserAgentId()
-          : quic_user_agent_id_,      // QUIC User Agent ID.
-      http2_enabled_,                 // Enable SPDY.
-      false,                          // Enable SDCH
-      URLRequestContextConfig::DISK,  // Type of http cache.
-      0,                              // Max size of http cache in bytes.
-      false,                          // Disable caching for HTTP responses.
-      cache_path.value(),  // Storage path for http cache and cookie storage.
-      user_agent_,         // User-Agent request header field.
-      "{}",                // JSON encoded experimental options.
-      "",                  // Data reduction proxy key.
-      "",                  // Data reduction proxy.
-      "",                  // Fallback data reduction proxy.
-      "",                  // Data reduction proxy secure proxy check URL.
-      std::move(mock_cert_verifier_),  // MockCertVerifier to use for testing
-                                       // purposes.
-      false,                           // Enable network quality estimator.
-      true,  // Enable bypassing of public key pinning for local trust anchors
-      ""));  // Certificate verifier cache data.
+  URLRequestContextConfigBuilder context_config_builder;
+  context_config_builder.enable_quic = quic_enabled_;   // Enable QUIC.
+  context_config_builder.enable_spdy = http2_enabled_;  // Enable SPDY

[mef, 2017/01/10 17:36:18]

nit: Enable HTTP/2. (including period).

[lilyhoughton, 2017/01/10 18:25:36]

Done.  Should the member itself be changed as well?  (Or perhaps an alias-member
added?)

[mef, 2017/01/10 18:36:13]

If anything we should rename it as spdy is deprecated, but it is called spdy all
over net stack, so we could leave it for now.

+  context_config_builder.storage_path =
+      cache_path.value();  // Storage path for http cache and cookie storage.

[mef, 2017/01/10 17:36:18]

I'd set http_cache = URLRequestContextConfig::DISK here explicitly.

[lilyhoughton, 2017/01/10 18:25:36]

Done.

+  context_config_builder.user_agent =
+      user_agent_;  // User-Agent request header field.
+  context_config_builder.mock_cert_verifier = std::move(
+      mock_cert_verifier_);  // MockCertVerifier to use for testing purposes.
+  std::unique_ptr<URLRequestContextConfig> config =
+      context_config_builder.Build();
 
   net::URLRequestContextBuilder context_builder;
 
   context_builder.set_accept_language(accept_language_);
 
   config->ConfigureURLRequestContextBuilder(&context_builder, net_log_.get(),
                                             file_thread_.get()->task_runner());
 
   std::unique_ptr<net::MappedHostResolver> mapped_host_resolver(
       new net::MappedHostResolver(
@@ skipping 61 matching lines @@
   event->Signal();
 }
 
 std::string CronetEnvironment::getDefaultQuicUserAgentId() const {
   return base::SysNSStringToUTF8([[NSBundle mainBundle]
              objectForInfoDictionaryKey:@"CFBundleDisplayName"]) +
          " Cronet/" + CRONET_VERSION;
 }
 
 }  // namespace cronet