Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: remoting/host/desktop_session_win.cc

Issue 2567003003: Removing unnecessary process ACL'ing for the remoting_desktop process (Closed)
Patch Set: Merging with ToT Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/host/win/wts_session_process_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/desktop_session_win.cc
diff --git a/remoting/host/desktop_session_win.cc b/remoting/host/desktop_session_win.cc
index 8edd612a9ca644240e82167a77ff3678886c5869..f1d9069bb83a44c4be0209b89b4ab6884b0835df 100644
--- a/remoting/host/desktop_session_win.cc
+++ b/remoting/host/desktop_session_win.cc
@@ -61,22 +61,6 @@ const wchar_t kDaemonIpcSecurityDescriptor[] =
SDDL_ACCESS_ALLOWED L";;" SDDL_GENERIC_ALL L";;;" SDDL_LOCAL_SYSTEM
L")";
-// This security descriptor is used to give the network process, running in the
-// local service context, the PROCESS_QUERY_LIMITED_INFORMATION access right.
-// It also gives SYSTEM full control of the process and PROCESS_VM_READ,
-// PROCESS_QUERY_INFORMATION, PROCESS_TERMINATE, and READ_CONTROL rights to the
-// built-in administrators group.
-const wchar_t kDesktopProcessSecurityDescriptor[] =
- SDDL_OWNER L":" SDDL_LOCAL_SYSTEM
- SDDL_GROUP L":" SDDL_LOCAL_SYSTEM
- SDDL_DACL L":"
- SDDL_ACCESS_ALLOWED L";;" SDDL_GENERIC_ALL L";;;" SDDL_LOCAL_SYSTEM
- L")("
- SDDL_ACCESS_ALLOWED L";;0x21411;;;" SDDL_BUILTIN_ADMINISTRATORS
- L")("
- SDDL_ACCESS_ALLOWED L";;0x1000;;;" SDDL_LOCAL_SERVICE
- L")";
-
// The command line parameters that should be copied from the service's command
// line to the desktop process.
const char* kCopiedSwitchNames[] = { switches::kV, switches::kVModule };
@@ -649,8 +633,7 @@ void DesktopSessionWin::OnSessionAttached(uint32_t session_id) {
std::unique_ptr<WtsSessionProcessDelegate> delegate(
new WtsSessionProcessDelegate(
io_task_runner_, std::move(target), launch_elevated,
- base::WideToUTF8(kDaemonIpcSecurityDescriptor),
- base::WideToUTF8(kDesktopProcessSecurityDescriptor)));
+ base::WideToUTF8(kDaemonIpcSecurityDescriptor)));
if (!delegate->Initialize(session_id)) {
TerminateSession();
return;
« no previous file with comments | « no previous file | remoting/host/win/wts_session_process_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698