Create ModeIndicatorController

Create ModeIndicatorController

This class is a controller of ModeIndicatorWidget.

BUG=177765
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226445

[Seigo Nonaka, 2013-10-02 03:27:51]

lgtm with nits

https://codereview.chromium.org/25670002/diff/1/chrome/browser/chromeos/input...
File chrome/browser/chromeos/input_method/mode_indicator_controller.cc (right):

https://codereview.chromium.org/25670002/diff/1/chrome/browser/chromeos/input...
chrome/browser/chromeos/input_method/mode_indicator_controller.cc:18:
DCHECK(manager);
no need to check mi_widget as well?

https://codereview.chromium.org/25670002/diff/1/chrome/browser/chromeos/input...
chrome/browser/chromeos/input_method/mode_indicator_controller.cc:56: //
TODO(komatsu): This showing mode indicator may not be necessary.
Eventually mode indicator also shows property right, doesn't it?

https://codereview.chromium.org/25670002/diff/1/chrome/browser/chromeos/input...
File chrome/browser/chromeos/input_method/mode_indicator_controller.h (right):

https://codereview.chromium.org/25670002/diff/1/chrome/browser/chromeos/input...
chrome/browser/chromeos/input_method/mode_indicator_controller.h:25: // This
class takes the ownership of the widget.
/widght/|mi_widget|/

[Hiro Komatsu, 2013-10-02 07:00:55]

Committing.

https://codereview.chromium.org/25670002/diff/1/chrome/browser/chromeos/input...
File chrome/browser/chromeos/input_method/mode_indicator_controller.cc (right):

https://codereview.chromium.org/25670002/diff/1/chrome/browser/chromeos/input...
chrome/browser/chromeos/input_method/mode_indicator_controller.cc:18:
DCHECK(manager);
On 2013/10/02 03:27:51, Seigo Nonaka wrote:
> no need to check mi_widget as well?

Done.

https://codereview.chromium.org/25670002/diff/1/chrome/browser/chromeos/input...
chrome/browser/chromeos/input_method/mode_indicator_controller.cc:56: //
TODO(komatsu): This showing mode indicator may not be necessary.
On 2013/10/02 03:27:51, Seigo Nonaka wrote:
> Eventually mode indicator also shows property right, doesn't it?

Not sure so far.  I removed this line and added the "Do nothing" comment.

https://codereview.chromium.org/25670002/diff/1/chrome/browser/chromeos/input...
File chrome/browser/chromeos/input_method/mode_indicator_controller.h (right):

https://codereview.chromium.org/25670002/diff/1/chrome/browser/chromeos/input...
chrome/browser/chromeos/input_method/mode_indicator_controller.h:25: // This
class takes the ownership of the widget.
On 2013/10/02 03:27:51, Seigo Nonaka wrote:
> /widght/|mi_widget|/

Done.

[commit-bot: I haz the power, 2013-10-02 07:08:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/komatsu@chromium.org/25670002/5001

[commit-bot: I haz the power, 2013-10-02 10:20:40]

Change committed as 226445