third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js - Issue 2566983004: DevTools: Fix profiler private field accesses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js

Issue 2566983004: DevTools: Fix profiler private field accesses. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js

index c30218d1957cc683041e47b67895c17bd13ec3a8..567ace99ace99bde3020e773a7d976023244720e 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js

@@ -419,8 +419,8 @@ Profiler.WritableProfileHeader = class extends Profiler.ProfileHeader {

this._jsonifiedProfile = null;

this.updateStatus(Common.UIString('Loaded'), false);

- if (this._profileType.profileBeingRecorded() === this)

- this._profileType.setProfileBeingRecorded(null);

+ if (this.profileType().profileBeingRecorded() === this)

+ this.profileType().setProfileBeingRecorded(null);

}

/**

@@ -512,7 +512,7 @@ Profiler.WritableProfileHeader = class extends Profiler.ProfileHeader {

}

this._fileName = this._fileName ||

- `${this._profileType.typeName()}-${new Date().toISO8601Compact()}${this._profileType.fileExtension()}`;

+ `${this.profileType().typeName()}-${new Date().toISO8601Compact()}${this.profileType().fileExtension()}`;

fileOutputStream.open(this._fileName, onOpenForSave.bind(this));

}