DevTools: Fix profiler private field accesses.

third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1018 matching lines @@
     var profile = new Profiler.HeapProfileHeader(target, this);
     this.setProfileBeingRecorded(profile);
     this.addProfile(profile);
     profile.updateStatus(Common.UIString('Snapshotting\u2026'));
 
     /**
      * @param {?string} error
      * @this {Profiler.HeapSnapshotProfileType}
      */
     function didTakeHeapSnapshot(error) {
-      var profile = this._profileBeingRecorded;
+      var profile = this.profileBeingRecorded();
       profile.title = Common.UIString('Snapshot %d', profile.uid);
       profile._finishLoad();
       this.setProfileBeingRecorded(null);
       this.dispatchEventToListeners(Profiler.ProfileType.Events.ProfileComplete, profile);
       callback();
     }
     target.heapProfilerAgent().takeHeapSnapshot(true, didTakeHeapSnapshot.bind(this));
   }
 
   /**
@@ skipping 13 matching lines @@
     var profile = this.profileBeingRecorded();
     if (!profile)
       return;
     var data = /** @type {{done: number, total: number, finished: boolean}} */ (event.data);
     profile.updateStatus(Common.UIString('%.0f%%', (data.done / data.total) * 100), true);
     if (data.finished)
       profile._prepareToLoad();
   }
 
   _resetProfiles() {
-    this._reset();
+    this.reset();
   }
 
   _snapshotReceived(profile) {
-    if (this._profileBeingRecorded === profile)
+    if (this.profileBeingRecorded() === profile)
       this.setProfileBeingRecorded(null);
     this.dispatchEventToListeners(Profiler.HeapSnapshotProfileType.SnapshotReceived, profile);
   }
 };
 
 Profiler.HeapSnapshotProfileType.TypeId = 'HEAP';
 Profiler.HeapSnapshotProfileType.SnapshotReceived = 'SnapshotReceived';
 
 /**
  * @unrestricted
@@ skipping 55 matching lines @@
     var currentIndex = Math.max(profileSamples.ids.length, profileSamples.max.length - 1);
     profileSamples.ids[currentIndex] = data.lastSeenObjectId;
     if (!profileSamples.max[currentIndex]) {
       profileSamples.max[currentIndex] = 0;
       profileSamples.sizes[currentIndex] = 0;
     }
     profileSamples.timestamps[currentIndex] = data.timestamp;
     if (profileSamples.totalTime < data.timestamp - profileSamples.timestamps[0])
       profileSamples.totalTime *= 2;
     this.dispatchEventToListeners(Profiler.TrackingHeapSnapshotProfileType.HeapStatsUpdate, this._profileSamples);
-    this._profileBeingRecorded.updateStatus(null, true);
+    this.profileBeingRecorded().updateStatus(null, true);
   }
 
   /**
    * @override
    * @return {boolean}
    */
   hasTemporaryView() {
     return true;
   }
 
@@ skipping 23 matching lines @@
       return;
     this._addNewProfile();
     var recordAllocationStacks = Common.moduleSetting('recordAllocationStacks').get();
     this.profileBeingRecorded().target().heapProfilerAgent().startTrackingHeapObjects(recordAllocationStacks);
   }
 
   _addNewProfile() {
     var target = UI.context.flavor(SDK.Target);
     this.setProfileBeingRecorded(new Profiler.HeapProfileHeader(target, this, undefined));
     this._profileSamples = new Profiler.TrackingHeapSnapshotProfileType.Samples();
-    this._profileBeingRecorded._profileSamples = this._profileSamples;
+    this.profileBeingRecorded()._profileSamples = this._profileSamples;
     this._recording = true;
-    this.addProfile(this._profileBeingRecorded);
-    this._profileBeingRecorded.updateStatus(Common.UIString('Recording\u2026'));
+    this.addProfile(/** @type {!Profiler.ProfileHeader} */ (this.profileBeingRecorded()));
+    this.profileBeingRecorded().updateStatus(Common.UIString('Recording\u2026'));
     this.dispatchEventToListeners(Profiler.TrackingHeapSnapshotProfileType.TrackingStarted);
   }
 
   _stopRecordingProfile() {
-    this._profileBeingRecorded.updateStatus(Common.UIString('Snapshotting\u2026'));
+    this.profileBeingRecorded().updateStatus(Common.UIString('Snapshotting\u2026'));
     /**
      * @param {?string} error
      * @this {Profiler.HeapSnapshotProfileType}
      */
     function didTakeHeapSnapshot(error) {
       var profile = this.profileBeingRecorded();
       if (!profile)
         return;
       profile._finishLoad();
       this._profileSamples = null;
       this.setProfileBeingRecorded(null);
       this.dispatchEventToListeners(Profiler.ProfileType.Events.ProfileComplete, profile);
     }
 
-    this._profileBeingRecorded.target().heapProfilerAgent().stopTrackingHeapObjects(
+    this.profileBeingRecorded().target().heapProfilerAgent().stopTrackingHeapObjects(
         true, didTakeHeapSnapshot.bind(this));
     this._recording = false;
     this.dispatchEventToListeners(Profiler.TrackingHeapSnapshotProfileType.TrackingStopped);
   }
 
   _toggleRecording() {
     if (this._recording)
       this._stopRecordingProfile();
     else
       this._startRecordingProfile();
@@ skipping 215 matching lines @@
     this._receiver = null;
     this._snapshotProxy = snapshotProxy;
     this.maxJSObjectId = snapshotProxy.maxJSObjectId();
     this._didCompleteSnapshotTransfer();
     this._workerProxy.startCheckingForLongRunningCalls();
     this.notifySnapshotReceived();
   }
 
   notifySnapshotReceived() {
     this._fulfillLoad(this._snapshotProxy);
-    this._profileType._snapshotReceived(this);
+    this.profileType()._snapshotReceived(this);
     if (this.canSaveToFile())
       this.dispatchEventToListeners(Profiler.ProfileHeader.Events.ProfileReceived);
   }
 
   // Hook point for tests.
   _wasShown() {
   }
 
   /**
    * @override
@@ skipping 20 matching lines @@
         Common.console.error('Failed to open temp file with heap snapshot');
         fileOutputStream.close();
       } else if (this._tempFile) {
         var delegate = new Profiler.SaveSnapshotOutputStreamDelegate(this);
         this._tempFile.copyToOutputStream(fileOutputStream, delegate);
       } else {
         this._onTempFileReady = onOpen.bind(this, accepted);
         this._updateSaveProgress(0, 1);
       }
     }
-    this._fileName = this._fileName || 'Heap-' + new Date().toISO8601Compact() + this._profileType.fileExtension();
+    this._fileName = this._fileName || 'Heap-' + new Date().toISO8601Compact() + this.profileType().fileExtension();
     fileOutputStream.open(this._fileName, onOpen.bind(this));
   }
 
   _updateSaveProgress(value, total) {
     var percentValue = ((total ? (value / total) : 0) * 100).toFixed(0);
     this.updateStatus(Common.UIString('Saving\u2026 %d%%', percentValue));
   }
 
   /**
    * @override
@@ skipping 574 matching lines @@
       var name = frameDiv.createChild('div');
       name.textContent = UI.beautifyFunctionName(frame.functionName);
       if (frame.scriptId) {
         var urlElement = this._linkifier.linkifyScriptLocation(
             this._target, String(frame.scriptId), frame.scriptName, frame.line - 1, frame.column - 1);
         frameDiv.appendChild(urlElement);
       }
     }
   }
 };