Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 2566943003: rel-note: automated rollback of internal change 138108562 (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/test_tools/quic_stream_sequencer_buffer_peer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/end_to_end_test.cc
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc
index 865fc76ba71bb0c570c5f6c68b07250ab763e590..3843bb923918569d51c696f8d6437936f28299e0 100644
--- a/net/tools/quic/end_to_end_test.cc
+++ b/net/tools/quic/end_to_end_test.cc
@@ -592,16 +592,20 @@ TEST_P(EndToEndTest, HandshakeSuccessful) {
QuicCryptoStream* crypto_stream =
QuicSessionPeer::GetCryptoStream(client_->client()->session());
QuicStreamSequencer* sequencer = QuicStreamPeer::sequencer(crypto_stream);
- EXPECT_NE(FLAGS_quic_release_crypto_stream_buffer,
- QuicStreamSequencerPeer::IsUnderlyingBufferAllocated(sequencer));
+ EXPECT_NE(
+ FLAGS_quic_release_crypto_stream_buffer &&
+ FLAGS_quic_reduce_sequencer_buffer_memory_life_time, // NOLINT
+ QuicStreamSequencerPeer::IsUnderlyingBufferAllocated(sequencer));
server_thread_->Pause();
QuicDispatcher* dispatcher =
QuicServerPeer::GetDispatcher(server_thread_->server());
QuicSession* server_session = dispatcher->session_map().begin()->second.get();
crypto_stream = QuicSessionPeer::GetCryptoStream(server_session);
sequencer = QuicStreamPeer::sequencer(crypto_stream);
- EXPECT_NE(FLAGS_quic_release_crypto_stream_buffer,
- QuicStreamSequencerPeer::IsUnderlyingBufferAllocated(sequencer));
+ EXPECT_NE(
+ FLAGS_quic_release_crypto_stream_buffer &&
+ FLAGS_quic_reduce_sequencer_buffer_memory_life_time, // NOLINT
+ QuicStreamSequencerPeer::IsUnderlyingBufferAllocated(sequencer));
}
TEST_P(EndToEndTest, SimpleRequestResponsev6) {
@@ -2640,8 +2644,10 @@ TEST_P(EndToEndTestServerPush, ServerPush) {
DVLOG(1) << "response body " << response_body;
EXPECT_EQ(expected_body, response_body);
}
- EXPECT_NE(FLAGS_quic_headers_stream_release_sequencer_buffer,
- QuicStreamSequencerPeer::IsUnderlyingBufferAllocated(sequencer));
+ EXPECT_NE(
+ FLAGS_quic_headers_stream_release_sequencer_buffer &&
+ FLAGS_quic_reduce_sequencer_buffer_memory_life_time, // NOLINT
+ QuicStreamSequencerPeer::IsUnderlyingBufferAllocated(sequencer));
}
TEST_P(EndToEndTestServerPush, ServerPushUnderLimit) {
@@ -2943,8 +2949,10 @@ TEST_P(EndToEndTest, ReleaseHeadersStreamBufferWhenIdle) {
QuicHeadersStream* headers_stream =
QuicSpdySessionPeer::GetHeadersStream(client_->client()->session());
QuicStreamSequencer* sequencer = QuicStreamPeer::sequencer(headers_stream);
- EXPECT_NE(FLAGS_quic_headers_stream_release_sequencer_buffer,
- QuicStreamSequencerPeer::IsUnderlyingBufferAllocated(sequencer));
+ EXPECT_NE(
+ FLAGS_quic_headers_stream_release_sequencer_buffer &&
+ FLAGS_quic_reduce_sequencer_buffer_memory_life_time, // NOLINT
+ QuicStreamSequencerPeer::IsUnderlyingBufferAllocated(sequencer));
}
class EndToEndBufferedPacketsTest : public EndToEndTest {
« no previous file with comments | « net/quic/test_tools/quic_stream_sequencer_buffer_peer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698