Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1229)

Unified Diff: net/quic/core/quic_stream_sequencer_buffer_test.cc

Issue 2566943003: rel-note: automated rollback of internal change 138108562 (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/core/quic_stream_sequencer_buffer_test.cc
diff --git a/net/quic/core/quic_stream_sequencer_buffer_test.cc b/net/quic/core/quic_stream_sequencer_buffer_test.cc
index 78a11ef57395be5c0c2af5b2dfe5a6e1b332839c..dcef21ead1f7f275debd2586fc839c92aceaac4b 100644
--- a/net/quic/core/quic_stream_sequencer_buffer_test.cc
+++ b/net/quic/core/quic_stream_sequencer_buffer_test.cc
@@ -110,7 +110,9 @@ TEST_F(QuicStreamSequencerBufferTest, OnStreamData0length) {
}
TEST_F(QuicStreamSequencerBufferTest, OnStreamDataWithinBlock) {
- EXPECT_FALSE(helper_->IsBufferAllocated());
+ if (FLAGS_quic_reduce_sequencer_buffer_memory_life_time) { // NOLINT
+ EXPECT_FALSE(helper_->IsBufferAllocated());
+ }
string source(1024, 'a');
size_t written;
clock_.AdvanceTime(QuicTime::Delta::FromSeconds(1));
@@ -469,6 +471,10 @@ TEST_F(QuicStreamSequencerBufferTest, GetReadableRegionsEmpty) {
TEST_F(QuicStreamSequencerBufferTest, ReleaseWholeBuffer) {
// Tests that buffer is not deallocated unless ReleaseWholeBuffer() is called.
+ if (!FLAGS_quic_reduce_sequencer_buffer_memory_life_time) { // NOLINT
+ // Won't release buffer when flag is off.
+ return;
+ }
string source(100, 'b');
clock_.AdvanceTime(QuicTime::Delta::FromSeconds(1));
« no previous file with comments | « net/quic/core/quic_stream_sequencer_buffer.cc ('k') | net/quic/test_tools/quic_stream_sequencer_buffer_peer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698