Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 256693007: Convert function.arguments to API-style accessor. (Closed)

Created:
6 years, 7 months ago by ulan
Modified:
6 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Convert function.arguments to API-style accessor. BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21014

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -31 lines) Patch
M src/accessors.h View 2 chunks +1 line, -16 lines 0 comments Download
M src/accessors.cc View 1 chunk +34 lines, -13 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ulan
PTAL
6 years, 7 months ago (2014-04-28 11:34:44 UTC) #1
Yang
On 2014/04/28 11:34:44, ulan wrote: > PTAL LGTM, but I think CL title is wrong.
6 years, 7 months ago (2014-04-28 11:37:22 UTC) #2
ulan
On 2014/04/28 11:37:22, Yang wrote: > On 2014/04/28 11:34:44, ulan wrote: > > PTAL > ...
6 years, 7 months ago (2014-04-28 11:38:22 UTC) #3
Yang
On 2014/04/28 11:38:22, ulan wrote: > On 2014/04/28 11:37:22, Yang wrote: > > On 2014/04/28 ...
6 years, 7 months ago (2014-04-28 11:38:55 UTC) #4
ulan
6 years, 7 months ago (2014-04-28 12:02:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r21014 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698