Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2566913002: Remove making added files as changed. (Closed)

Created:
4 years ago by scheglov
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove making added files as changed. This is not done (in a way) during removing files. We just forget everything about all files. So, we don't need an additional complication here. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1e59cc0b9f27d471fb9c4874043f77490b80e3fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years ago (2016-12-12 03:08:55 UTC) #1
Brian Wilkerson
lgtm
4 years ago (2016-12-12 14:16:37 UTC) #2
scheglov
4 years ago (2016-12-12 16:36:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1e59cc0b9f27d471fb9c4874043f77490b80e3fe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698