Issue 2566893002: Change the way tasks are registered

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2566893002: Change the way tasks are registered (Closed)

Created:
4 years ago by Brian Wilkerson

Modified:
4 years ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+93 lines, -121 lines)			Patch
M	pkg/analyzer/lib/plugin/task.dart	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	pkg/analyzer/lib/src/context/context.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/engine.dart	View	3 chunks	+92 lines, -9 lines	0 comments	Download
M	pkg/analyzer/lib/src/plugin/engine_plugin.dart	View	7 chunks	+0 lines, -98 lines	0 comments	Download

Total messages: 5 (2 generated)

Brian Wilkerson

Second attempt. There was code relying on the side-effect that when asking for the task ...

4 years ago (2016-12-11 23:49:20 UTC) #2

Brian Wilkerson

4 years ago (2016-12-11 23:59:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b7f1a96ae5fbbe181bf5db2b2be957b55504a859 (presubmit successful).