Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 256683002: Comment out lkcr/lkgr fetching from chromium/src.git's git cache (Closed)

Created:
6 years, 8 months ago by Ryan Tseng
Modified:
6 years, 8 months ago
Reviewers:
szager, agable, szager1
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Comment out lkcr/lkgr fetching from chromium/src.git's git cache This isn't doing anything, and is currently costing 20 seconds of idle time per bot_update run. Lets remove it until we convert lkcr/lkgr to tags. BUG=261741 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=266055

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M gclient_scm.py View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ryan Tseng
This should shave 20 seconds off bot_update. ptal.
6 years, 8 months ago (2014-04-24 23:38:10 UTC) #1
Ryan Tseng
Evidence: [0:00:02] running "git fetch -v --progress origin +refs/tags/lkgr:refs/tags/lkgr" in "/b/build/slave/cache_dir/chromium.googlesource.com-chromium-src" [0:00:03] fatal: Couldn't find ...
6 years, 8 months ago (2014-04-24 23:39:03 UTC) #2
szager1
lgtm But only because the terminal spew is distracting. I don't think 20 seconds is ...
6 years, 8 months ago (2014-04-24 23:56:48 UTC) #3
Ryan Tseng
The CQ bit was checked by hinoka@google.com
6 years, 8 months ago (2014-04-25 00:00:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@google.com/256683002/1
6 years, 8 months ago (2014-04-25 00:00:37 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 00:02:22 UTC) #6
Message was sent while issue was closed.
Change committed as 266055

Powered by Google App Engine
This is Rietveld 408576698