Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: chrome/browser/win/enumerate_modules_model.cc

Issue 2566733003: Annotate Trusteer Rapport < 3.6 as incompatible with Chrome. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/win/enumerate_modules_model.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/win/enumerate_modules_model.cc
diff --git a/chrome/browser/win/enumerate_modules_model.cc b/chrome/browser/win/enumerate_modules_model.cc
index 98aaffa7cb5706427dec229b7925b000e0cfe723..9b3ceff7533e3a9659ed7ddab60f6c778926aabe 100644
--- a/chrome/browser/win/enumerate_modules_model.cc
+++ b/chrome/browser/win/enumerate_modules_model.cc
@@ -518,6 +518,7 @@ void ModuleEnumerator::ScanImplModule(size_t index) {
void ModuleEnumerator::ScanImplFinish() {
// TODO(chrisha): Annotate any modules that are suspicious/bad.
+ AnnotateBadModules();
ReportThirdPartyMetrics();
@@ -694,6 +695,19 @@ void ModuleEnumerator::CollapsePath(Module* entry) {
}
}
+void ModuleEnumerator::AnnotateBadModules() {
+ for (auto& module : *enumerated_modules_) {
+ if (module.name == L"rapportnikko.dll") {
+ base::Version version(base::UTF16ToASCII(module.version));
+ base::Version good("3.6");
+ if (version.CompareTo(good) < 0) {
+ module.status = ModuleStatus::CONFIRMED_BAD;
+ module.recommended_action = RecommendedAction::UNINSTALL;
+ }
+ }
+ }
+}
+
void ModuleEnumerator::ReportThirdPartyMetrics() {
static const wchar_t kMicrosoft[] = L"Microsoft ";
static const wchar_t kGoogle[] = L"Google Inc";
« no previous file with comments | « chrome/browser/win/enumerate_modules_model.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698