Issue 256673002: HID: Support top-level collection usages in device info.

Issue 256673002: HID: Support top-level collection usages in device info. (Closed)

Created:
6 years, 8 months ago by Ken Rockot(use gerrit already)

Modified:
6 years, 8 months ago

Reviewers:
jracle (use Gerrit), rpaquay

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

HID: Support top-level collection usages in device info. This CL exists as an effort to actually land https://codereview.chromium.org/225513005/. This applies a small fix to the hid_service_win.cc module. BUG=359560 TBR=rpaquay TBR=jracle@logitech.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266066

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1225 lines, -76 lines)			Patch
M	chrome/browser/extensions/api/hid/hid_device_manager.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/hid.idl	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	device/device_tests.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	device/hid/hid.gyp	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	device/hid/hid_connection_linux.h	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	device/hid/hid_connection_linux.cc	View	2 chunks	+1 line, -50 lines	0 comments	Download
M	device/hid/hid_device_info.h	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	device/hid/hid_device_info.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
A	device/hid/hid_report_descriptor.h	View	1 chunk	+38 lines, -0 lines	0 comments	Download
A	device/hid/hid_report_descriptor.cc	View	1 chunk	+61 lines, -0 lines	0 comments	Download
A	device/hid/hid_report_descriptor_item.h	View	1 chunk	+183 lines, -0 lines	0 comments	Download
A	device/hid/hid_report_descriptor_item.cc	View	1 chunk	+112 lines, -0 lines	0 comments	Download
A	device/hid/hid_report_descriptor_unittest.cc	View	1 chunk	+613 lines, -0 lines	0 comments	Download
M	device/hid/hid_service_linux.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	device/hid/hid_service_linux.cc	View	6 chunks	+93 lines, -5 lines	0 comments	Download
M	device/hid/hid_service_mac.cc	View	1 chunk	+18 lines, -4 lines	0 comments	Download
M	device/hid/hid_service_win.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
A	device/hid/hid_usage_and_page.h	View	1 chunk	+61 lines, -0 lines	0 comments	Download
A +	device/hid/hid_usage_and_page.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ken Rockot(use gerrit already)

Committed patchset #1 manually as r266066 (presubmit successful).

6 years, 8 months ago (2014-04-25 00:17:03 UTC) #1

jracle (use Gerrit)

6 years, 8 months ago (2014-04-25 07:21:43 UTC) #2

Message was sent while issue was closed.

On 2014/04/25 00:17:03, Ken Rockot wrote:
> Committed patchset #1 manually as r266066 (presubmit successful).

Excellent, thanks for landing the patch!
We're good now :)

Expand Messages | Collapse Messages