Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: services/service_manager/runner/host/child_process_host.h

Issue 2566663004: Revert of Build services as standalone executables (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/service_manager/runner/host/child_process_host.h
diff --git a/services/service_manager/runner/host/child_process_host.h b/services/service_manager/runner/host/child_process_host.h
index ab87d02ae29048e8c89489bfe762c80f6c8bc269..eb14adbccf69d1004d965566885d9d7fff205e61 100644
--- a/services/service_manager/runner/host/child_process_host.h
+++ b/services/service_manager/runner/host/child_process_host.h
@@ -36,25 +36,26 @@
// This class represents a "child process host". Handles launching and
// connecting a platform-specific "pipe" to the child, and supports joining the
-// child process. Currently runs a single service, loaded from a standalone
-// service executable on the file system.
+// child process. Currently runs a single app (loaded from the file system).
//
// This class is not thread-safe. It should be created/used/destroyed on a
// single thread.
//
// Note: Does not currently work on Windows before Vista.
+// Note: After |Start()|, |StartApp| must be called and this object must
+// remained alive until the |on_app_complete| callback is called.
class ChildProcessHost {
public:
using ProcessReadyCallback = base::Callback<void(base::ProcessId)>;
// |name| is just for debugging ease. We will spawn off a process so that it
- // can be sandboxed if |start_sandboxed| is true. |service_path| is a path to
- // the service executable we wish to start.
+ // can be sandboxed if |start_sandboxed| is true. |app_path| is a path to the
+ // service we wish to start.
ChildProcessHost(base::TaskRunner* launch_process_runner,
NativeRunnerDelegate* delegate,
bool start_sandboxed,
const Identity& target,
- const base::FilePath& service_path);
+ const base::FilePath& app_path);
virtual ~ChildProcessHost();
// |Start()|s the child process; calls |DidStart()| (on the thread on which
@@ -76,7 +77,7 @@
NativeRunnerDelegate* delegate_ = nullptr;
bool start_sandboxed_ = false;
Identity target_;
- base::FilePath service_path_;
+ const base::FilePath app_path_;
base::Process child_process_;
// Used to initialize the Mojo IPC channel between parent and child.
« no previous file with comments | « services/service_manager/runner/host/child_process_base.cc ('k') | services/service_manager/runner/host/child_process_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698