Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: services/service_manager/service_manager.h

Issue 2566663003: Fix UAF on singleton service instances (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | services/service_manager/service_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/service_manager/service_manager.h
diff --git a/services/service_manager/service_manager.h b/services/service_manager/service_manager.h
index ebfe845735dd4276110f8ca7215b5aaedd26d613..3711ca7218cf0ce01cd055056ba9c436213ccbeb 100644
--- a/services/service_manager/service_manager.h
+++ b/services/service_manager/service_manager.h
@@ -119,6 +119,10 @@ class ServiceManager {
// running as a different user if one is available that services all users.
Instance* GetExistingInstance(const Identity& identity) const;
+ // Erases any identities mapping to |instance|. Following this call it is
+ // impossible for any call to GetExistingInstance() to return |instance|.
+ void EraseInstanceIdentity(Instance* instance);
+
void NotifyServiceStarted(const Identity& identity, base::ProcessId pid);
void NotifyServiceFailedToStart(const Identity& identity);
« no previous file with comments | « no previous file | services/service_manager/service_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698