Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2566623002: Worker: Factor out common functions into ThreadedObjectProxyBase (Closed)

Created:
4 years ago by nhiroki
Modified:
4 years ago
Reviewers:
falken
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Factor out common functions into ThreadedObjectProxyBase Several functions in InProcessWorkerObjectProxy and ThreadedWorkletObjectProxy are common. This CL introduces ThreadedMessagingProxyBase class, factors out the functions into the base class and makes the both proxies inherit it. [Class relationships after this CL] On MainThread / On WorkerThread ThreadedMessagingProxyBase / ThreadedObjectProxyBase - InProcessWorkerMessagingProxy / - InProcessWorkerObjectProxy - ThreadedWorkletMessagingProxy / - ThreadedWorkletObjectProxy BUG=667357 Committed: https://crrev.com/9083392315f8b2ba599185c6b63af718ac4c6efb Cr-Commit-Position: refs/heads/master@{#437503}

Patch Set 1 #

Patch Set 2 : fix layout tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -167 lines) Patch
M third_party/WebKit/Source/core/workers/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h View 4 chunks +10 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp View 5 chunks +11 lines, -52 lines 0 comments Download
A third_party/WebKit/Source/core/workers/ThreadedObjectProxyBase.h View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/workers/ThreadedObjectProxyBase.cpp View 1 1 chunk +71 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.h View 2 chunks +10 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp View 2 chunks +7 lines, -71 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
nhiroki
PTAL, thanks!
4 years ago (2016-12-09 06:31:19 UTC) #12
falken
lgtm
4 years ago (2016-12-09 06:45:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566623002/60001
4 years ago (2016-12-09 07:39:55 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years ago (2016-12-09 09:30:21 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-09 09:32:11 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9083392315f8b2ba599185c6b63af718ac4c6efb
Cr-Commit-Position: refs/heads/master@{#437503}

Powered by Google App Engine
This is Rietveld 408576698