third_party/hidapi/hidapi_linux.c.patch - Issue 25666010: Adding third party library hidapi

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/hidapi/hidapi_linux.c.patch

Issue 25666010: Adding third party library hidapi (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 diff --git a/third_party/hidapi/hidapi_linux.c b/third_party/hidapi/hidapi_linux .c
	Kees Cook 2013/12/04 20:49:36 What's the purpose of this patch? Is this just sil What's the purpose of this patch? Is this just silencing compiler warnings about a useless compare against unsigned enum? Bei Zhang 2013/12/10 22:24:11 Yes, it is. Show quoted text On 2013/12/04 20:49:36, Kees Cook wrote: > What's the purpose of this patch? Is this just silencing compiler warnings about > a useless compare against unsigned enum? Yes, it is.
	2 index 38f6753..21d04c0 100644

	3 --- a/third_party/hidapi/hidapi_linux.c

	4 +++ b/third_party/hidapi/hidapi_linux.c

	5 @@ -305,7 +305,7 @@ static int get_device_string(hid_device *dev, enum device_st ring_id key, wchar_t

	6 const char *str;

	7 const char *key_str = NULL;

	8

	9 - if (key >= 0 && key < DEVICE_STRING_COUN T) {

	10 + if (key < DEVICE_STRING_COUNT) {

	11 key_str = device_string_names[ke y];

	12 } else {

	13 ret = -1;

OLD	NEW