Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/dom/scripts/systemnative.py

Issue 25666008: Adding custom element lifecycle processing to all attribute modifiers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/systemnative.py
diff --git a/tools/dom/scripts/systemnative.py b/tools/dom/scripts/systemnative.py
index 8dbe0e224ec7e1724b57227cbb913930aee21c5a..1235e801a4c4c2b19fad63d5e09065a870e35e37 100644
--- a/tools/dom/scripts/systemnative.py
+++ b/tools/dom/scripts/systemnative.py
@@ -551,7 +551,8 @@ class DartiumBackend(HtmlDartGenerator):
[attr],
'void',
False,
- 'SetterRaisesException' in attr.ext_attrs)
+ 'SetterRaisesException' in attr.ext_attrs,
+ requires_custom_element_callback=True)
def AddIndexer(self, element_type):
"""Adds all the methods required to complete implementation of List."""
@@ -730,7 +731,8 @@ class DartiumBackend(HtmlDartGenerator):
arguments,
return_type,
return_type_is_nullable,
- raises_dom_exception):
+ raises_dom_exception,
+ requires_custom_element_callback=False):
ext_attrs = node.ext_attrs
@@ -789,7 +791,7 @@ class DartiumBackend(HtmlDartGenerator):
if 'Reflect' in ext_attrs:
cpp_arguments = [self._GenerateWebCoreReflectionAttributeName(node)]
- if ext_attrs.get('CustomElementCallbacks') == 'Enable':
+ if ext_attrs.get('CustomElementCallbacks') == 'Enable' or requires_custom_element_callback:
self._cpp_impl_includes.add('"core/dom/CustomElementCallbackDispatcher.h"')
needs_custom_element_callbacks = True
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698