Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 25666006: Get rid of the HInstanceSize instruction. (Closed)

Created:
7 years, 2 months ago by Benedikt Meurer
Modified:
7 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Get rid of the HInstanceSize instruction. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -136 lines) Patch
M src/arm/lithium-arm.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.h View 3 chunks +6 lines, -21 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Hey Michi, This one was marked with TODO(mstarzinger), so you get to review this CL. ...
7 years, 2 months ago (2013-10-02 13:42:03 UTC) #1
Michael Starzinger
LGTM. Thanks for that.
7 years, 2 months ago (2013-10-02 15:37:09 UTC) #2
Benedikt Meurer
7 years, 2 months ago (2013-10-04 19:04:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17116 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698