Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: content/renderer/render_view_impl.cc

Issue 2566583002: Change allowed bindings to be per RenderFrame instead of per RenderView. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index af38e868c82c846dfa1b38f55b042d56b3f82387..f4555973d17fce1e7ec938ea235bc76ced8b3eba 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -716,11 +716,6 @@ void RenderViewImpl::Initialize(
new IdleUserDetector(this);
- if (command_line.HasSwitch(switches::kDomAutomationController))
- enabled_bindings_ |= BINDINGS_POLICY_DOM_AUTOMATION;
- if (command_line.HasSwitch(switches::kStatsCollectionController))
- enabled_bindings_ |= BINDINGS_POLICY_STATS_COLLECTION;
-
GetContentClient()->renderer()->RenderViewCreated(this);
// Ensure that sandbox flags are inherited from an opener in a different
@@ -1208,7 +1203,6 @@ bool RenderViewImpl::OnMessageReceived(const IPC::Message& message) {
OnScrollFocusedEditableNodeIntoRect)
IPC_MESSAGE_HANDLER(ViewMsg_SetPageScale, OnSetPageScale)
IPC_MESSAGE_HANDLER(ViewMsg_Zoom, OnZoom)
- IPC_MESSAGE_HANDLER(ViewMsg_AllowBindings, OnAllowBindings)
IPC_MESSAGE_HANDLER(ViewMsg_SetInitialFocus, OnSetInitialFocus)
IPC_MESSAGE_HANDLER(ViewMsg_UpdateTargetURL_ACK, OnUpdateTargetURLAck)
IPC_MESSAGE_HANDLER(ViewMsg_UpdateWebPreferences, OnUpdateWebPreferences)
@@ -2075,10 +2069,6 @@ bool RenderViewImpl::ShouldDisplayScrollbars(int width, int height) const {
disable_scrollbars_size_limit_.height() <= height));
}
-int RenderViewImpl::GetEnabledBindings() const {
- return enabled_bindings_;
-}
-
bool RenderViewImpl::GetContentStateImmediately() const {
return send_content_state_immediately_;
}
@@ -2141,22 +2131,6 @@ void RenderViewImpl::OnSetZoomLevel(
SetZoomLevel(zoom_level);
}
-void RenderViewImpl::OnAllowBindings(int enabled_bindings_flags) {
- if ((enabled_bindings_flags & BINDINGS_POLICY_WEB_UI) &&
- !(enabled_bindings_ & BINDINGS_POLICY_WEB_UI)) {
- // WebUIExtensionData deletes itself when we're destroyed.
- new WebUIExtensionData(this);
- }
-
- enabled_bindings_ |= enabled_bindings_flags;
-
- // Keep track of the total bindings accumulated in this process.
- RenderProcess::current()->AddBindings(enabled_bindings_flags);
-
- if (main_render_frame_)
- main_render_frame_->MaybeEnableMojoBindings();
-}
-
void RenderViewImpl::OnUpdateWebPreferences(const WebPreferences& prefs) {
webkit_preferences_ = prefs;
ApplyWebPreferencesInternal(webkit_preferences_, webview(), compositor_deps_);

Powered by Google App Engine
This is Rietveld 408576698