content/browser/frame_host/navigation_controller_impl_browsertest.cc - Issue 2566583002: Change allowed bindings to be per RenderFrame instead of per RenderView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl_browsertest.cc

Issue 2566583002: Change allowed bindings to be per RenderFrame instead of per RenderView. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/interstitial_page_impl.cc ('k') | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_controller_impl_browsertest.cc

diff --git a/content/browser/frame_host/navigation_controller_impl_browsertest.cc b/content/browser/frame_host/navigation_controller_impl_browsertest.cc

index 4b98ab1516f2c28dd46662533ba0461b03ac2d82..db6dcaf79c8bf3cbf8a4ec990448a97417b7929f 100644

--- a/content/browser/frame_host/navigation_controller_impl_browsertest.cc

+++ b/content/browser/frame_host/navigation_controller_impl_browsertest.cc

@@ -558,7 +558,7 @@ IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest,

std::string(kChromeUIGpuHost));

EXPECT_TRUE(NavigateToURL(shell(), web_ui_page));

EXPECT_EQ(BINDINGS_POLICY_WEB_UI,

- shell()->web_contents()->GetRenderViewHost()->GetEnabledBindings());

+ shell()->web_contents()->GetMainFrame()->GetEnabledBindings());

ShellAddedObserver observer;

std::string page_url = embedded_test_server()->GetURL(