Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5613)

Unified Diff: chrome/renderer/chrome_render_view_observer.cc

Issue 2566583002: Change allowed bindings to be per RenderFrame instead of per RenderView. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_render_view_observer.cc
diff --git a/chrome/renderer/chrome_render_view_observer.cc b/chrome/renderer/chrome_render_view_observer.cc
index b90084854a7afb4800af674e0a94831f41884919..da99bd7b53854579017b6fd40c893ab8aae10612 100644
--- a/chrome/renderer/chrome_render_view_observer.cc
+++ b/chrome/renderer/chrome_render_view_observer.cc
@@ -163,7 +163,9 @@ void ChromeRenderViewObserver::OnSetVisuallyDeemphasized(bool deemphasized) {
void ChromeRenderViewObserver::DidCommitProvisionalLoad(
blink::WebLocalFrame* frame,
bool is_new_navigation) {
- if ((render_view()->GetEnabledBindings() & content::BINDINGS_POLICY_WEB_UI) &&
+ auto* render_frame = content::RenderFrame::FromWebFrame(frame);
+ if (render_frame->IsMainFrame() &&
+ (render_frame->GetEnabledBindings() & content::BINDINGS_POLICY_WEB_UI) &&
!webui_javascript_.empty()) {
for (const auto& script : webui_javascript_)
render_view()->GetMainRenderFrame()->ExecuteJavaScript(script);

Powered by Google App Engine
This is Rietveld 408576698