content/browser/renderer_host/render_view_host_unittest.cc - Issue 2566583002: Change allowed bindings to be per RenderFrame instead of per RenderView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_unittest.cc

Issue 2566583002: Change allowed bindings to be per RenderFrame instead of per RenderView. (Closed)

Patch Set: rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_view_host_unittest.cc

diff --git a/content/browser/renderer_host/render_view_host_unittest.cc b/content/browser/renderer_host/render_view_host_unittest.cc

index 57418fc2e6421a4f17050cb83ac7d1bae9d3de84..ea0e8f7a3a3481bc8c15fcb7ef28fabc7e0c6f8b 100644

--- a/content/browser/renderer_host/render_view_host_unittest.cc

+++ b/content/browser/renderer_host/render_view_host_unittest.cc

@@ -88,8 +88,9 @@ TEST_F(RenderViewHostTest, DontGrantBindingsToSharedProcess) {

std::unique_ptr<TestWebContents> new_web_contents(

TestWebContents::Create(browser_context(), rvh()->GetSiteInstance()));

- rvh()->AllowBindings(BINDINGS_POLICY_WEB_UI);

- EXPECT_FALSE(rvh()->GetEnabledBindings() & BINDINGS_POLICY_WEB_UI);

+ main_rfh()->AllowBindings(BINDINGS_POLICY_WEB_UI);

+ EXPECT_FALSE(rvh()->GetMainFrame()->GetEnabledBindings() &

Charlie Reis 2017/01/19 17:58:55 nit: This one should be main_rfh(), too. :)

Sam McNally 2017/01/19 23:34:09 Done.

+ BINDINGS_POLICY_WEB_UI);

}

class MockDraggingRenderViewHostDelegateView