Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 2566583002: Change allowed bindings to be per RenderFrame instead of per RenderView. (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index eb809c414d4fa0186b1a930643f4e0f6560174de..fc9ce8a95856235069ea07c53ced3ed90a7a59c6 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -176,6 +176,8 @@ class CONTENT_EXPORT RenderFrameHostImpl
const TextSurroundingSelectionCallback& callback,
int max_length) override;
void RequestFocusedFormFieldData(FormFieldDataCallback& callback) override;
+ void AllowBindings(int binding_flags) override;
+ int GetEnabledBindings() const override;
// mojom::FrameHost
void GetInterfaceProvider(
@@ -327,11 +329,6 @@ class CONTENT_EXPORT RenderFrameHostImpl
render_frame_proxy_host_ = proxy;
}
- // Returns a bitwise OR of bindings types that have been enabled for this
- // RenderFrameHostImpl's RenderView. See BindingsPolicy for details.
- // TODO(creis): Make bindings frame-specific, to support cases like <webview>.
- int GetEnabledBindings();
-
// The unique ID of the latest NavigationEntry that this RenderFrameHost is
// showing. This may change even when this frame hasn't committed a page,
// such as for a new subframe navigation in a different frame.
@@ -1104,6 +1101,7 @@ class CONTENT_EXPORT RenderFrameHostImpl
mojo::Binding<mojom::FrameHost> frame_host_binding_;
mojom::FramePtr frame_;
+ mojom::FrameBindingsControlAssociatedPtr frame_bindings_control_;
// If this is true then this object was created in response to a renderer
// initiated request. Init() will be called, and until then navigation
@@ -1131,6 +1129,10 @@ class CONTENT_EXPORT RenderFrameHostImpl
std::unique_ptr<AssociatedInterfaceProviderImpl>
remote_associated_interfaces_;
+ // A bitwise OR of bindings types that have been enabled for this RenderFrame.
+ // See BindingsPolicy for details.
+ int enabled_bindings_ = 0;
+
// NOTE: This must be the last member.
base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698