Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: chrome/browser/ui/browser_commands.cc

Issue 2566573002: DevTools: Open Elements panel sooner on Inspect Element (Closed)
Patch Set: Missed one showConsolePanel Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser_commands.h" 5 #include "chrome/browser/ui/browser_commands.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/metrics/histogram_macros.h" 8 #include "base/metrics/histogram_macros.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "build/build_config.h" 10 #include "build/build_config.h"
(...skipping 1057 matching lines...) Expand 10 before | Expand all | Expand 10 after
1068 content::RecordAction(UserMetricsAction("FocusNextPane")); 1068 content::RecordAction(UserMetricsAction("FocusNextPane"));
1069 browser->window()->RotatePaneFocus(true); 1069 browser->window()->RotatePaneFocus(true);
1070 } 1070 }
1071 1071
1072 void FocusPreviousPane(Browser* browser) { 1072 void FocusPreviousPane(Browser* browser) {
1073 content::RecordAction(UserMetricsAction("FocusPreviousPane")); 1073 content::RecordAction(UserMetricsAction("FocusPreviousPane"));
1074 browser->window()->RotatePaneFocus(false); 1074 browser->window()->RotatePaneFocus(false);
1075 } 1075 }
1076 1076
1077 void ToggleDevToolsWindow(Browser* browser, DevToolsToggleAction action) { 1077 void ToggleDevToolsWindow(Browser* browser, DevToolsToggleAction action) {
1078 if (action.type() == DevToolsToggleAction::kShowConsole) 1078 if (action.type() == DevToolsToggleAction::kShowConsolePanel)
1079 content::RecordAction(UserMetricsAction("DevTools_ToggleConsole")); 1079 content::RecordAction(UserMetricsAction("DevTools_ToggleConsole"));
1080 else 1080 else
1081 content::RecordAction(UserMetricsAction("DevTools_ToggleWindow")); 1081 content::RecordAction(UserMetricsAction("DevTools_ToggleWindow"));
1082 DevToolsWindow::ToggleDevToolsWindow(browser, action); 1082 DevToolsWindow::ToggleDevToolsWindow(browser, action);
1083 } 1083 }
1084 1084
1085 bool CanOpenTaskManager() { 1085 bool CanOpenTaskManager() {
1086 #if !defined(OS_ANDROID) 1086 #if !defined(OS_ANDROID)
1087 return true; 1087 return true;
1088 #else 1088 #else
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
1331 app_name, true /* trusted_source */, gfx::Rect(), browser->profile())); 1331 app_name, true /* trusted_source */, gfx::Rect(), browser->profile()));
1332 app_browser->tab_strip_model()->AppendWebContents(contents, true); 1332 app_browser->tab_strip_model()->AppendWebContents(contents, true);
1333 1333
1334 contents->GetMutableRendererPrefs()->can_accept_load_drops = false; 1334 contents->GetMutableRendererPrefs()->can_accept_load_drops = false;
1335 contents->GetRenderViewHost()->SyncRendererPrefs(); 1335 contents->GetRenderViewHost()->SyncRendererPrefs();
1336 app_browser->window()->Show(); 1336 app_browser->window()->Show();
1337 } 1337 }
1338 #endif // BUILDFLAG(ENABLE_EXTENSIONS) 1338 #endif // BUILDFLAG(ENABLE_EXTENSIONS)
1339 1339
1340 } // namespace chrome 1340 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser_command_controller.cc ('k') | chrome/browser/ui/views/extensions/extension_popup.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698