Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc

Issue 2566573002: DevTools: Open Elements panel sooner on Inspect Element (Closed)
Patch Set: Missed one showConsolePanel Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_toggle_action.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/extensions/file_manager/private_api_misc.h" 5 #include "chrome/browser/chromeos/extensions/file_manager/private_api_misc.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <set> 9 #include <set>
10 #include <vector> 10 #include <vector>
(...skipping 395 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 const std::unique_ptr<Params> params(Params::Create(*args_)); 406 const std::unique_ptr<Params> params(Params::Create(*args_));
407 EXTENSION_FUNCTION_VALIDATE(params); 407 EXTENSION_FUNCTION_VALIDATE(params);
408 408
409 switch (params->type) { 409 switch (params->type) {
410 case extensions::api::file_manager_private::INSPECTION_TYPE_NORMAL: 410 case extensions::api::file_manager_private::INSPECTION_TYPE_NORMAL:
411 // Open inspector for foreground page. 411 // Open inspector for foreground page.
412 DevToolsWindow::OpenDevToolsWindow(GetSenderWebContents()); 412 DevToolsWindow::OpenDevToolsWindow(GetSenderWebContents());
413 break; 413 break;
414 case extensions::api::file_manager_private::INSPECTION_TYPE_CONSOLE: 414 case extensions::api::file_manager_private::INSPECTION_TYPE_CONSOLE:
415 // Open inspector for foreground page and bring focus to the console. 415 // Open inspector for foreground page and bring focus to the console.
416 DevToolsWindow::OpenDevToolsWindow(GetSenderWebContents(), 416 DevToolsWindow::OpenDevToolsWindow(
417 DevToolsToggleAction::ShowConsole()); 417 GetSenderWebContents(), DevToolsToggleAction::ShowConsolePanel());
418 break; 418 break;
419 case extensions::api::file_manager_private::INSPECTION_TYPE_ELEMENT: 419 case extensions::api::file_manager_private::INSPECTION_TYPE_ELEMENT:
420 // Open inspector for foreground page in inspect element mode. 420 // Open inspector for foreground page in inspect element mode.
421 DevToolsWindow::OpenDevToolsWindow(GetSenderWebContents(), 421 DevToolsWindow::OpenDevToolsWindow(GetSenderWebContents(),
422 DevToolsToggleAction::Inspect()); 422 DevToolsToggleAction::Inspect());
423 break; 423 break;
424 case extensions::api::file_manager_private::INSPECTION_TYPE_BACKGROUND: 424 case extensions::api::file_manager_private::INSPECTION_TYPE_BACKGROUND:
425 // Open inspector for background page. 425 // Open inspector for background page.
426 extensions::devtools_util::InspectBackgroundPage( 426 extensions::devtools_util::InspectBackgroundPage(
427 extension(), Profile::FromBrowserContext(browser_context())); 427 extension(), Profile::FromBrowserContext(browser_context()));
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
694 base::File::Error result) { 694 base::File::Error result) {
695 if (result != base::File::FILE_OK) { 695 if (result != base::File::FILE_OK) {
696 Respond(Error("Failed to execute the action.")); 696 Respond(Error("Failed to execute the action."));
697 return; 697 return;
698 } 698 }
699 699
700 Respond(NoArguments()); 700 Respond(NoArguments());
701 } 701 }
702 702
703 } // namespace extensions 703 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_toggle_action.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698