Issue 256653006: Move setup of SkPictCopyInfo into SkPicture::clone

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 256653006: Move setup of SkPictCopyInfo into SkPicture::clone (Closed)

Created:
6 years, 7 months ago by robertphillips

Modified:
6 years, 7 months ago

Reviewers:
scroggo, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Move setup of SkPictCopyInfo into SkPicture::clone This refactoring seemed sufficiently fraught that I've broken it out of a larger patch to move fBitmapHeap out of SkPictureRecord/SkPicturePlayback and into SkPicture. SkPicturePlayback's friending of SkPicture should be temporary and just allows SkPicture to access items that will be moving into it soon. Committed: http://code.google.com/p/skia/source/detail?r=14440

Patch Set 1 #

Patch Set 2 : Fixed overlength lines #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -61 lines)			Patch
M	src/core/SkPicture.cpp	View	1	2 chunks	+62 lines, -0 lines	0 comments	Download
M	src/core/SkPicturePlayback.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/core/SkPicturePlayback.cpp	View		2 chunks	+2 lines, -61 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

robertphillips

The CQ bit was checked by robertphillips@google.com

6 years, 7 months ago (2014-04-29 17:03:26 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/256653006/20001

6 years, 7 months ago (2014-04-29 17:03:53 UTC) #4

Message was sent while issue was closed.

Change committed as 14440

Expand Messages | Collapse Messages