third_party/WebKit/Source/core/dom/Document.cpp - Issue 2566523003: Fix meta-theme-color not working outside <head>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2566523003: Fix meta-theme-color not working outside <head> (Closed)

Patch Set: update Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index ef948f518c45cd9cd95a1baff6af7c947baaaac2..c2fc48126fc4c47964ec06e48ece916e16d83579 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -5397,14 +5397,15 @@ Vector<IconURL> Document::iconURLs(int iconTypesMask) {

}

Color Document::themeColor() const {

- for (HTMLMetaElement* metaElement =

- head() ? Traversal<HTMLMetaElement>::firstChild(*head()) : 0;

- metaElement;

- metaElement = Traversal<HTMLMetaElement>::nextSibling(*metaElement)) {

+ auto rootElement = documentElement();

+ if (!rootElement)

+ return Color();

+ for (HTMLMetaElement& metaElement :

+ Traversal<HTMLMetaElement>::descendantsOf(*rootElement)) {

Color color = Color::transparent;

- if (equalIgnoringCase(metaElement->name(), "theme-color") &&

+ if (equalIgnoringCase(metaElement.name(), "theme-color") &&

CSSParser::parseColor(

- color, metaElement->content().getString().stripWhiteSpace(), true))

+ color, metaElement.content().getString().stripWhiteSpace(), true))

return color;

}

return Color();

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/DocumentTest.cpp » ('j') | no next file with comments »