Chromium Code Reviews Chromium Code Reviews
Issue 2566523003:
Fix meta-theme-color not working outside <head> (Closed)
| Index: third_party/WebKit/Source/core/dom/Document.cpp |
| diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp |
| index ef948f518c45cd9cd95a1baff6af7c947baaaac2..1b993609e73df4b89e499f078ef10bfe53d4423d 100644 |
| --- a/third_party/WebKit/Source/core/dom/Document.cpp |
| +++ b/third_party/WebKit/Source/core/dom/Document.cpp |
| @@ -5397,15 +5397,22 @@ Vector<IconURL> Document::iconURLs(int iconTypesMask) { |
| } |
| Color Document::themeColor() const { |
| - for (HTMLMetaElement* metaElement = |
| - head() ? Traversal<HTMLMetaElement>::firstChild(*head()) : 0; |
| - metaElement; |
| - metaElement = Traversal<HTMLMetaElement>::nextSibling(*metaElement)) { |
| - Color color = Color::transparent; |
| - if (equalIgnoringCase(metaElement->name(), "theme-color") && |
| - CSSParser::parseColor( |
| - color, metaElement->content().getString().stripWhiteSpace(), true)) |
| - return color; |
| + for (HTMLElement* child = |
|
tkent
2016/12/09 06:07:25
Do you need nested-|for|s? Why don't you do someth
lpy
2016/12/09 08:43:43
Done.
|
| + documentElement() |
| + ? Traversal<HTMLElement>::firstChild(*documentElement()) |
| + : 0; |
| + child; child = Traversal<HTMLElement>::nextSibling(*child)) { |
| + for (HTMLMetaElement* metaElement = |
| + Traversal<HTMLMetaElement>::firstChild(*child); |
| + metaElement; |
| + metaElement = Traversal<HTMLMetaElement>::nextSibling(*metaElement)) { |
| + Color color = Color::transparent; |
| + if (equalIgnoringCase(metaElement->name(), "theme-color") && |
| + CSSParser::parseColor( |
| + color, metaElement->content().getString().stripWhiteSpace(), |
| + true)) |
| + return color; |
| + } |
| } |
| return Color(); |
| } |
