third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp - Issue 2566503002: Adds HTTP check to PresentationRequest creation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp

Issue 2566503002: Adds HTTP check to PresentationRequest creation. (Closed)

Patch Set: Updates browser test. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/presentation/presentation-api.html ('k') | third_party/WebKit/Source/modules/presentation/PresentationRequestTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp b/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp

index 4da9bf0140fbdf5c812882a35fdf014531c36a8d..29fc7a518b3d60011ba066d7d11687b26a0453b3 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp

@@ -84,7 +84,8 @@ PresentationRequest* PresentationRequest::create(

for (size_t i = 0; i < urls.size(); ++i) {

const KURL& parsedUrl = KURL(executionContext->url(), urls[i]);

- if (!parsedUrl.isValid() || parsedUrl.protocolIsAbout()) {

+ if (!parsedUrl.isValid() ||

+ !(parsedUrl.protocolIsInHTTPFamily() || parsedUrl.protocolIs("cast"))) {

exceptionState.throwDOMException(

SyntaxError, "'" + urls[i] + "' can't be resolved to a valid URL.");

return nullptr;