Adds HTTP check to PresentationRequest creation.

third_party/WebKit/Source/modules/presentation/PresentationRequestTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/presentation/PresentationRequest.h"
 
 #include "bindings/core/v8/V8BindingForTesting.h"
 #include "core/dom/ExceptionCode.h"
 #include "platform/weborigin/KURL.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 11 matching lines @@
   WTF::Vector<KURL> requestUrls = request->urls();
   EXPECT_EQ(static_cast<size_t>(1), requestUrls.size());
   EXPECT_TRUE(requestUrls[0].isValid());
   EXPECT_EQ("https://example.com/", requestUrls[0].getString());
 }
 
 TEST(PresentationRequestTest, TestMultipleUrlConstructor) {
   V8TestingScope scope;
   WTF::Vector<String> urls;
   urls.append("https://example.com");
-  urls.append("cast://deadbeef?param=foo");
+  urls.append("http://deadbeef?param=foo");
 
   PresentationRequest* request = PresentationRequest::create(
       scope.getExecutionContext(), urls, scope.getExceptionState());
   ASSERT_FALSE(scope.getExceptionState().hadException());
 
   WTF::Vector<KURL> requestUrls = request->urls();
   EXPECT_EQ(static_cast<size_t>(2), requestUrls.size());
   EXPECT_TRUE(requestUrls[0].isValid());
   EXPECT_EQ("https://example.com/", requestUrls[0].getString());
   EXPECT_TRUE(requestUrls[1].isValid());
-  EXPECT_EQ("cast://deadbeef?param=foo", requestUrls[1].getString());
+  EXPECT_EQ("http://deadbeef/?param=foo", requestUrls[1].getString());
+}
+
+TEST(PresentationRequestTest, TestMultipleUrlConstructorInvalidURLFamily) {
+  V8TestingScope scope;
+  WTF::Vector<String> urls;
+  urls.append("https://example.com");
+  urls.append("cast://deadbeef?param=foo");

[zhaobin, 2017/01/18 18:58:22]

Some layout tests uses url with "cast://". They may break if we are rejecting
those urls now. Could you please double check?

src/third_party/WebKit/LayoutTests/presentation/presentation-start.html
src/third_party/WebKit/LayoutTests/presentation/presentation-navigation-multipleurls.html

[mark a. foltz, 2017/01/18 20:26:01]

Yeah, now that we have tests for cast:// we should allow it in
PresentationRequest.cpp.

+
+  PresentationRequest::create(scope.getExecutionContext(), urls,
+                              scope.getExceptionState());
+  ASSERT_TRUE(scope.getExceptionState().hadException());
+
+  EXPECT_EQ(SyntaxError, scope.getExceptionState().code());
 }
 
 TEST(PresentationRequestTest, TestMultipleUrlConstructorInvalidUrl) {
   V8TestingScope scope;
   WTF::Vector<String> urls;
   urls.append("https://example.com");
   urls.append("");
 
   PresentationRequest::create(scope.getExecutionContext(), urls,
                               scope.getExceptionState());
@@ skipping 32 matching lines @@
   WTF::Vector<String> urls;
 
   PresentationRequest::create(scope.getExecutionContext(), urls,
                               scope.getExceptionState());
   EXPECT_TRUE(scope.getExceptionState().hadException());
   EXPECT_EQ(NotSupportedError, scope.getExceptionState().code());
 }
 
 }  // anonymous namespace
 }  // namespace blink