Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Issue 2566483002: [promisehook] Add is_promisehook_enabled (Closed)

Created:
4 years ago by gsathya
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, ofrobots, adamk
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promisehook] Add is_promisehook_enabled This will be used in CSA to check if any promisehook is set. -- Adds a is_promisehook_enabled_ field to the isolate and helper methods. -- Adds this field to the ExternalReference table. -- Adds a helper method to access this from CSA Note -- this patch doesn't actually add the ability to attach the hook yet. BUG=v8:4643 Committed: https://crrev.com/d778b36f0c98934f6dd1046ee20e04d60dfac212 Cr-Commit-Position: refs/heads/master@{#41607}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rename var #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M src/assembler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/assembler.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/code-stub-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/external-reference-table.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/isolate.h View 2 chunks +10 lines, -0 lines 0 comments Download
M src/isolate.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
gsathya
4 years ago (2016-12-08 20:05:07 UTC) #5
Igor Sheludko
lgtm with a nit: https://codereview.chromium.org/2566483002/diff/1/src/code-stub-assembler.cc File src/code-stub-assembler.cc (right): https://codereview.chromium.org/2566483002/diff/1/src/code-stub-assembler.cc#newcode8241 src/code-stub-assembler.cc:8241: Node* is_debug_active = Please update ...
4 years ago (2016-12-08 22:50:57 UTC) #9
gsathya
https://codereview.chromium.org/2566483002/diff/1/src/code-stub-assembler.cc File src/code-stub-assembler.cc (right): https://codereview.chromium.org/2566483002/diff/1/src/code-stub-assembler.cc#newcode8241 src/code-stub-assembler.cc:8241: Node* is_debug_active = On 2016/12/08 22:50:57, Igor Sheludko wrote: ...
4 years ago (2016-12-08 23:42:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566483002/20001
4 years ago (2016-12-09 00:21:51 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-09 06:56:52 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-09 06:57:30 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d778b36f0c98934f6dd1046ee20e04d60dfac212
Cr-Commit-Position: refs/heads/master@{#41607}

Powered by Google App Engine
This is Rietveld 408576698