Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2566473002: Fix include guards for QUIC files. (Closed)

Created:
4 years ago by Ryan Hamilton
Modified:
4 years ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix include guards for QUIC files. Committed: https://crrev.com/3a16d5e578c004d73c9a76a0485b29aadf7adcf6 Cr-Commit-Position: refs/heads/master@{#437409}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+398 lines, -398 lines) Patch
M net/quic/chromium/bidirectional_stream_quic_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/chromium/crypto/proof_source_chromium.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/chromium/crypto/proof_verifier_chromium.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/chromium/network_connection.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_chromium_alarm_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session_peer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_stream.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_chromium_connection_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_chromium_packet_reader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_chromium_packet_writer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_connection_logger.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_http_stream.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_utils_chromium.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/cubic.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/cubic_bytes.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/general_loss_algorithm.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/hybrid_slow_start.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/loss_detection_interface.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/pacing_sender.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/prr_sender.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/rtt_stats.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/send_algorithm_interface.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_base.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_bytes.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_packets.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/windowed_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/aead_base_decrypter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/aead_base_encrypter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/aes_128_gcm_12_decrypter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/aes_128_gcm_12_encrypter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/cert_compressor.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/chacha20_poly1305_decrypter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/chacha20_poly1305_encrypter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/channel_id.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/common_cert_set.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/crypto_framer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/crypto_handshake.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/crypto_handshake_message.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/crypto_protocol.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/crypto_secret_boxer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/crypto_server_config_protobuf.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/crypto_utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/curve25519_key_exchange.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/ephemeral_key_source.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/key_exchange.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/local_strike_register_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/null_decrypter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/null_encrypter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/p256_key_exchange.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/proof_source.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/proof_verifier.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/properties_based_quic_server_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/quic_compressed_certs_cache.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/quic_decrypter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/quic_encrypter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/quic_random.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/quic_server_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/scoped_evp_aead_ctx.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/strike_register.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/strike_register_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/frames/quic_frame.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/frames/quic_path_close_frame.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/frames/quic_stream_frame.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/interval.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/interval_set.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_address_mismatch.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_alarm.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_alarm_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_arena_scoped_ptr.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_bandwidth.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_blocked_writer_interface.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_buffer_allocator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_buffered_packet_store.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_bug_tracker.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_client_promised_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_client_push_promise_index.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_client_session_base.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_config.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_connection.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_connection_stats.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_constants.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_crypto_stream.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_data_reader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_data_writer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_error_codes.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_flags.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_flow_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_frame_list.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_framer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_header_list.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_iovector.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_multipath_received_packet_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_multipath_sent_packet_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_multipath_transmissions_map.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_one_block_arena.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_packet_creator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_packet_generator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_packet_writer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_packets.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_received_packet_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_sent_packet_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_sent_packet_manager_interface.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_server_id.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_server_session_base.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_session.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_simple_buffer_allocator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_socket_address_coder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_spdy_session.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_spdy_stream.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_stream_sequencer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_stream_sequencer_buffer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_stream_sequencer_buffer_interface.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_tag.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_time.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_types.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_unacked_packet_map.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_versions.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_write_blocked_list.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/spdy_utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quartc/quartc_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quartc/quartc_task_runner_interface.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_epoll_alarm_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_simple_crypto_server_stream_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_simple_per_connection_packet_writer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_simple_server.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_simple_server_packet_writer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream_base.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/stateless_rejector.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/test_tools/mock_quic_server_session_visitor.h View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 2565563002 Patch 1

Dependent Patchsets:

Issue 2561893002 Patch 1
Issue 2561893002 Patch 20001
Issue 2561893002 Patch 40001

Messages

Total messages: 9 (4 generated)
Ryan Hamilton
4 years ago (2016-12-08 19:57:50 UTC) #2
Zhongyi Shi
lgtm Thanks for clean this up!
4 years ago (2016-12-08 20:07:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566473002/1
4 years ago (2016-12-08 21:31:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 01:27:09 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-09 01:29:28 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3a16d5e578c004d73c9a76a0485b29aadf7adcf6
Cr-Commit-Position: refs/heads/master@{#437409}

Powered by Google App Engine
This is Rietveld 408576698