Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2068)

Unified Diff: chrome/browser/chromeos/login/ui/login_display_host_impl.cc

Issue 2566443005: cros: Replace WizardController string constants with OobeScreen values. (Closed)
Patch Set: Initial upload Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/ui/login_display_host_impl.cc
diff --git a/chrome/browser/chromeos/login/ui/login_display_host_impl.cc b/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
index c8bb5f64af540ec2d152b1735947eb3ff9b658e2..daedf5562444c9ed9b8e8ef0793becc97a3db740 100644
--- a/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
+++ b/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
@@ -172,7 +172,7 @@ class AnimationObserver : public ui::ImplicitAnimationObserver {
// from ShowLoginWizard(), and sometimes from OnLanguageSwitchedCallback()
// (if locale was updated).
void ShowLoginWizardFinish(
- const std::string& first_screen_name,
+ chromeos::OobeScreen first_screen_name,
const chromeos::StartupCustomizationDocument* startup_manifest,
chromeos::LoginDisplayHost* display_host) {
TRACE_EVENT0("chromeos", "ShowLoginWizard::ShowLoginWizardFinish");
@@ -192,14 +192,14 @@ void ShowLoginWizardFinish(
struct ShowLoginWizardSwitchLanguageCallbackData {
explicit ShowLoginWizardSwitchLanguageCallbackData(
- const std::string& first_screen_name,
+ chromeos::OobeScreen first_screen_name,
const chromeos::StartupCustomizationDocument* startup_manifest,
chromeos::LoginDisplayHost* display_host)
: first_screen_name(first_screen_name),
startup_manifest(startup_manifest),
display_host(display_host) {}
- const std::string first_screen_name;
+ const chromeos::OobeScreen first_screen_name;
const chromeos::StartupCustomizationDocument* const startup_manifest;
chromeos::LoginDisplayHost* const display_host;
@@ -530,7 +530,7 @@ AutoEnrollmentController* LoginDisplayHostImpl::GetAutoEnrollmentController() {
return auto_enrollment_controller_.get();
}
-void LoginDisplayHostImpl::StartWizard(const std::string& first_screen_name) {
+void LoginDisplayHostImpl::StartWizard(OobeScreen first_screen_name) {
DisableKeyboardOverscroll();
startup_sound_honors_spoken_feedback_ = false;
@@ -550,7 +550,8 @@ void LoginDisplayHostImpl::StartWizard(const std::string& first_screen_name) {
if (!login_window_)
LoadURL(GURL(kOobeURL));
- DVLOG(1) << "Starting wizard, first_screen_name: " << first_screen_name;
+ DVLOG(1) << "Starting wizard, first_screen_name: "
+ << GetOobeScreenName(first_screen_name);
// Create and show the wizard.
// Note, dtor of the old WizardController should be called before ctor of the
// new one, because "default_controller()" is updated there. So pure "reset()"
@@ -1246,11 +1247,11 @@ void LoginDisplayHostImpl::DisableRestrictiveProxyCheckForTest() {
// Declared in login_wizard.h so that others don't need to depend on our .h.
// TODO(nkostylev): Split this into a smaller functions.
-void ShowLoginWizard(const std::string& first_screen_name) {
+void ShowLoginWizard(OobeScreen first_screen_name) {
if (browser_shutdown::IsTryingToQuit())
return;
- VLOG(1) << "Showing OOBE screen: " << first_screen_name;
+ VLOG(1) << "Showing OOBE screen: " << GetOobeScreenName(first_screen_name);
chromeos::input_method::InputMethodManager* manager =
chromeos::input_method::InputMethodManager::Get();
@@ -1282,7 +1283,7 @@ void ShowLoginWizard(const std::string& first_screen_name) {
LoginDisplayHostImpl* display_host = new LoginDisplayHostImpl(screen_bounds);
bool show_app_launch_splash_screen =
- (first_screen_name == WizardController::kAppLaunchSplashScreenName);
+ (first_screen_name == OobeScreen::SCREEN_APP_LAUNCH_SPLASH);
if (show_app_launch_splash_screen) {
const std::string& auto_launch_app_id =
KioskAppManager::Get()->GetAutoLaunchApp();
@@ -1299,11 +1300,12 @@ void ShowLoginWizard(const std::string& first_screen_name) {
g_browser_process->platform_part()
->browser_policy_connector_chromeos()
->GetPrescribedEnrollmentConfig();
- if (enrollment_config.should_enroll() && first_screen_name.empty()) {
+ if (enrollment_config.should_enroll() &&
+ first_screen_name == OobeScreen::SCREEN_UNKNOWN) {
// Shows networks screen instead of enrollment screen to resume the
// interrupted auto start enrollment flow because enrollment screen does
// not handle flaky network. See http://crbug.com/332572
- display_host->StartWizard(WizardController::kNetworkScreenName);
+ display_host->StartWizard(OobeScreen::SCREEN_OOBE_NETWORK);
return;
}
@@ -1319,8 +1321,9 @@ void ShowLoginWizard(const std::string& first_screen_name) {
}
bool show_login_screen =
- (first_screen_name.empty() && StartupUtils::IsOobeCompleted()) ||
- first_screen_name == WizardController::kLoginScreenName;
+ (first_screen_name == OobeScreen::SCREEN_UNKNOWN &&
+ StartupUtils::IsOobeCompleted()) ||
+ first_screen_name == OobeScreen::SCREEN_SPECIAL_LOGIN;
if (show_login_screen) {
display_host->StartSignInScreen(LoginScreenContext());

Powered by Google App Engine
This is Rietveld 408576698