chrome/browser/ui/webui/chromeos/login/oobe_ui.cc - Issue 2566443005: cros: Replace WizardController string constants with OobeScreen values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/oobe_ui.cc

Issue 2566443005: cros: Replace WizardController string constants with OobeScreen values. (Closed)

Patch Set: Address comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/chromeos/login/oobe_ui.cc

diff --git a/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc b/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc

index a3a89142286a097feb853a4176c9964680876661..c2a694b0b3103244ebdf0a61e55c4f85fa7f60af 100644

--- a/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc

+++ b/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc

@@ -591,9 +591,8 @@ void OobeUI::RemoveObserver(Observer* observer) {

observer_list_.RemoveObserver(observer);

}

-void OobeUI::OnCurrentScreenChanged(const std::string& screen) {

+void OobeUI::OnCurrentScreenChanged(OobeScreen new_screen) {

previous_screen_ = current_screen_;

- OobeScreen new_screen = GetOobeScreenFromName(screen);

const bool should_dim =

std::find(std::begin(kDimOverlayScreenIds),