Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5405)

Unified Diff: chrome/browser/chromeos/login/screens/update_screen_browsertest.cc

Issue 2566443005: cros: Replace WizardController string constants with OobeScreen values. (Closed)
Patch Set: Address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/screens/update_screen_browsertest.cc
diff --git a/chrome/browser/chromeos/login/screens/update_screen_browsertest.cc b/chrome/browser/chromeos/login/screens/update_screen_browsertest.cc
index 24f8643383abbbce72f80e2f437a60af25198f12..d44d751848cd23dd5f59333500a1d543ccbe01f6 100644
--- a/chrome/browser/chromeos/login/screens/update_screen_browsertest.cc
+++ b/chrome/browser/chromeos/login/screens/update_screen_browsertest.cc
@@ -44,10 +44,10 @@ const char kStubWifiGuid[] = "wlan0";
class UpdateScreenTest : public WizardInProcessBrowserTest {
public:
- UpdateScreenTest() : WizardInProcessBrowserTest("update"),
- fake_update_engine_client_(NULL),
- network_portal_detector_(NULL) {
- }
+ UpdateScreenTest()
+ : WizardInProcessBrowserTest(OobeScreen::SCREEN_OOBE_UPDATE),
+ fake_update_engine_client_(nullptr),
+ network_portal_detector_(nullptr) {}
protected:
void SetUpInProcessBrowserTestFixture() override {
@@ -182,9 +182,9 @@ IN_PROC_BROWSER_TEST_F(UpdateScreenTest, TestUpdateAvailable) {
// Check that OOBE will resume back at this screen.
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(StartupUtils::IsOobeCompleted());
- EXPECT_EQ(
- update_screen_->screen_id(),
- g_browser_process->local_state()->GetString(prefs::kOobeScreenPending));
+ EXPECT_EQ(update_screen_->screen_id(),
+ GetOobeScreenFromName(g_browser_process->local_state()->GetString(
+ prefs::kOobeScreenPending)));
}
IN_PROC_BROWSER_TEST_F(UpdateScreenTest, TestErrorIssuingUpdateCheck) {
« no previous file with comments | « chrome/browser/chromeos/login/screens/update_screen.cc ('k') | chrome/browser/chromeos/login/screens/user_image_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698