Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2566443002: mac: Add tracing for -[BrowserCrApplication sendEvent:]. (Closed)

Created:
4 years ago by erikchen
Modified:
4 years ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Add tracing for -[BrowserCrApplication sendEvent:]. This captures work triggered from NSEvents for tracing. BUG=669116 Committed: https://crrev.com/ad0b46843bbcca3ef126402974d9ceaaf136bef5 Cr-Commit-Position: refs/heads/master@{#437334}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : missing include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/chrome_browser_application_mac.mm View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
erikchen
rsesek: Please review.
4 years ago (2016-12-08 18:38:32 UTC) #2
Robert Sesek
lgtm
4 years ago (2016-12-08 18:43:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566443002/20001
4 years ago (2016-12-08 18:54:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/350696)
4 years ago (2016-12-08 19:37:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566443002/40001
4 years ago (2016-12-08 20:22:31 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-08 20:58:47 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-08 21:00:46 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ad0b46843bbcca3ef126402974d9ceaaf136bef5
Cr-Commit-Position: refs/heads/master@{#437334}

Powered by Google App Engine
This is Rietveld 408576698