Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2566343002: [inspector_protocol] Support redirects and types whitelisting. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
kozy
CC:
chromium-reviews, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -6 lines) Patch
M CodeGenerator.py View 2 chunks +10 lines, -0 lines 0 comments Download
M lib/DispatcherBase_cpp.template View 3 chunks +15 lines, -1 line 2 comments Download
M lib/DispatcherBase_h.template View 2 chunks +3 lines, -1 line 0 comments Download
M templates/TypeBuilder_cpp.template View 4 chunks +12 lines, -4 lines 0 comments Download
M templates/TypeBuilder_h.template View 4 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dgozman
Take a look please.
4 years ago (2016-12-12 23:05:06 UTC) #2
kozy
lgtm https://codereview.chromium.org/2566343002/diff/1/lib/DispatcherBase_cpp.template File lib/DispatcherBase_cpp.template (right): https://codereview.chromium.org/2566343002/diff/1/lib/DispatcherBase_cpp.template#newcode253 lib/DispatcherBase_cpp.template:253: for (const auto& pair : redirects) Do we ...
4 years ago (2016-12-12 23:10:29 UTC) #3
dgozman
https://codereview.chromium.org/2566343002/diff/1/lib/DispatcherBase_cpp.template File lib/DispatcherBase_cpp.template (right): https://codereview.chromium.org/2566343002/diff/1/lib/DispatcherBase_cpp.template#newcode253 lib/DispatcherBase_cpp.template:253: for (const auto& pair : redirects) On 2016/12/12 23:10:29, ...
4 years ago (2016-12-12 23:27:12 UTC) #4
dgozman
4 years ago (2016-12-12 23:27:28 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
344219890fe40130571f5a5b17f261a654e3b8cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698