Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 256633002: cros: Fix demo app could bring up CCD. (Closed)

Created:
6 years, 8 months ago by xiyuan
Modified:
6 years, 8 months ago
Reviewers:
rkc
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

cros: Fix demo app could bring up CCD. The bug happens because kiosk command switches is in place after profile is loaded. As a result, CCD app is loaded. BUG=366382 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266075

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M chrome/browser/chromeos/login/demo_mode/demo_app_launcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc View 1 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
xiyuan
6 years, 8 months ago (2014-04-24 19:43:08 UTC) #1
rkc
lgtm
6 years, 8 months ago (2014-04-24 20:48:21 UTC) #2
xiyuan
The CQ bit was checked by xiyuan@chromium.org
6 years, 8 months ago (2014-04-24 21:25:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/256633002/20001
6 years, 8 months ago (2014-04-24 21:44:03 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 00:56:58 UTC) #5
Message was sent while issue was closed.
Change committed as 266075

Powered by Google App Engine
This is Rietveld 408576698