net/ssl/ssl_platform_key_win.cc - Issue 2566273008: Use SecKeyCreateSignature on macOS 10.12 and later.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ssl/ssl_platform_key_win.cc

Issue 2566273008: Use SecKeyCreateSignature on macOS 10.12 and later. (Closed)

Patch Set: rsleevi comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/ssl/ssl_platform_key_win.cc

diff --git a/net/ssl/ssl_platform_key_win.cc b/net/ssl/ssl_platform_key_win.cc

index e0b1b9e7ef65d26583595143d0058c6d99390924..f325a45a9d9cf2977780ff42b5eb123a32a59be2 100644

--- a/net/ssl/ssl_platform_key_win.cc

+++ b/net/ssl/ssl_platform_key_win.cc

@@ -248,7 +248,7 @@ class SSLPlatformKeyCNG : public ThreadedSSLPrivateKey::Delegate {

} // namespace

scoped_refptr<SSLPrivateKey> FetchClientCertPrivateKey(

- X509Certificate* certificate) {

+ const X509Certificate* certificate) {

// Rather than query the private key for metadata, extract the public key from

// the certificate without using Windows APIs. CAPI and CNG do not

// consistently work depending on the system. See https://crbug.com/468345.

« no previous file with comments | « net/ssl/ssl_platform_key_nss.cc ('k') | net/ssl/ssl_private_key_test_util.h » ('j') | no next file with comments »