net/ssl/ssl_platform_key_chromecast.cc - Issue 2566273008: Use SecKeyCreateSignature on macOS 10.12 and later.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ssl/ssl_platform_key_chromecast.cc

Issue 2566273008: Use SecKeyCreateSignature on macOS 10.12 and later. (Closed)

Patch Set: rsleevi comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/ssl/ssl_platform_key_chromecast.cc

diff --git a/net/ssl/ssl_platform_key_chromecast.cc b/net/ssl/ssl_platform_key_chromecast.cc

index e7857e8b654cefc100aa74b5075eb090bebe4b07..b913e77f828c16fed95e330481d9d25f8ca5844a 100644

--- a/net/ssl/ssl_platform_key_chromecast.cc

+++ b/net/ssl/ssl_platform_key_chromecast.cc

@@ -119,7 +119,7 @@ class SSLPlatformKeyChromecast : public ThreadedSSLPrivateKey::Delegate {

} // namespace

scoped_refptr<SSLPrivateKey> FetchClientCertPrivateKey(

- X509Certificate* certificate) {

+ const X509Certificate* certificate) {

crypto::ScopedSECKEYPrivateKey key(

PK11_FindKeyByAnyCert(certificate->os_cert_handle(), nullptr));

if (!key) {

« no previous file with comments | « net/ssl/ssl_platform_key_android_unittest.cc ('k') | net/ssl/ssl_platform_key_mac.h » ('j') | no next file with comments »