Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2566263002: Reduce flakiness of http_client_stays_alive_test. (Closed)

Created:
4 years ago by Florian Schneider
Modified:
4 years ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reduce flakiness of http_client_stays_alive_test. Give it more time before failing. BUG= R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/1ca079a472a4133e943a48d7f551c91440ef647b

Patch Set 1 #

Patch Set 2 : Split up ipv6 test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M tests/standalone/io/http_client_stays_alive_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/socket_ipv6_test.dart View 1 1 chunk +7 lines, -7 lines 1 comment Download

Messages

Total messages: 7 (3 generated)
Florian Schneider
4 years ago (2016-12-12 18:53:57 UTC) #3
Florian Schneider
https://codereview.chromium.org/2566263002/diff/20001/tests/standalone/io/socket_ipv6_test.dart File tests/standalone/io/socket_ipv6_test.dart (right): https://codereview.chromium.org/2566263002/diff/20001/tests/standalone/io/socket_ipv6_test.dart#newcode127 tests/standalone/io/socket_ipv6_test.dart:127: testIPv6toIPv6(); /// none: ok Unrelated, but seems good in ...
4 years ago (2016-12-12 21:05:14 UTC) #4
kustermann
LGTM
4 years ago (2016-12-12 21:12:08 UTC) #5
Florian Schneider
4 years ago (2016-12-12 21:50:39 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
1ca079a472a4133e943a48d7f551c91440ef647b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698