Chromium Code Reviews
DescriptionMerge to m56: Ensure spoken feedback keyboard hooks prevent re-injection of key up events
Due to the way we handle keyboard events, we need to explicitly handle prevention of both key down and key up events in js.
If we do not, accelerators that happen to trigger via release e.g. the high contrast shortcut, will activate.
BUG=668771
TBR=dtseng@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2552013003
Cr-Commit-Position: refs/heads/master@{#436653}
(cherry picked from commit fa04240e9ca5c26709789a3ebfb5ed522a1d4355)
Committed: https://chromium.googlesource.com/chromium/src/+/5406e90c70e3030c25a654c5c056cf74f820bfef
Patch Set 1 #
Messages
Total messages: 7 (4 generated)
|
|||||||||||||||||||