Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2566253002: Merge to m56: Ensure spoken feedback keyboard hooks prevent re-injection of key up events (Closed)

Created:
4 years ago by David Tseng
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Merge to m56: Ensure spoken feedback keyboard hooks prevent re-injection of key up events Due to the way we handle keyboard events, we need to explicitly handle prevention of both key down and key up events in js. If we do not, accelerators that happen to trigger via release e.g. the high contrast shortcut, will activate. BUG=668771 TBR=dtseng@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2552013003 Cr-Commit-Position: refs/heads/master@{#436653} (cherry picked from commit fa04240e9ca5c26709789a3ebfb5ed522a1d4355) Committed: https://chromium.googlesource.com/chromium/src/+/5406e90c70e3030c25a654c5c056cf74f820bfef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/keyboard_handler.js View 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566253002/1
4 years ago (2016-12-12 18:40:39 UTC) #3
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years ago (2016-12-12 18:40:40 UTC) #5
David Tseng
4 years ago (2016-12-12 18:52:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5406e90c70e3030c25a654c5c056cf74f820bfef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698