Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6741)

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

Issue 256623002: Implemented inline login dialog for Chrome OS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments addressed. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
diff --git a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
index 41957ef16ffa180024465da04b9a7dcc04a7750c..7127eed5d63c0c64aa79a6c4c78a59bd7e14f3d9 100644
--- a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
+++ b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
@@ -27,7 +27,6 @@
#include "components/signin/core/browser/signin_error_controller.h"
#include "components/signin/core/browser/signin_oauth_helper.h"
#include "content/public/browser/storage_partition.h"
-#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_ui.h"
#include "google_apis/gaia/gaia_auth_fetcher.h"
#include "google_apis/gaia/gaia_auth_util.h"
@@ -180,14 +179,6 @@ InlineLoginHandlerImpl::InlineLoginHandlerImpl()
InlineLoginHandlerImpl::~InlineLoginHandlerImpl() {}
-void InlineLoginHandlerImpl::RegisterMessages() {
- InlineLoginHandler::RegisterMessages();
-
- web_ui()->RegisterMessageCallback("switchToFullTab",
- base::Bind(&InlineLoginHandlerImpl::HandleSwitchToFullTabMessage,
- base::Unretained(this)));
-}
-
void InlineLoginHandlerImpl::SetExtraInitParams(base::DictionaryValue& params) {
params.SetInteger("authMode", InlineLoginHandler::kDesktopAuthMode);
@@ -236,24 +227,6 @@ void InlineLoginHandlerImpl::SetExtraInitParams(base::DictionaryValue& params) {
source, one_click_signin::HISTOGRAM_SHOWN);
}
-void InlineLoginHandlerImpl::HandleSwitchToFullTabMessage(
- const base::ListValue* args) {
- base::string16 url_str;
- CHECK(args->GetString(0, &url_str));
-
- content::WebContents* web_contents = web_ui()->GetWebContents();
- GURL main_frame_url(web_contents->GetURL());
- main_frame_url = net::AppendOrReplaceQueryParameter(
- main_frame_url, "frameUrl", base::UTF16ToASCII(url_str));
- chrome::NavigateParams params(
- Profile::FromWebUI(web_ui()),
- net::AppendOrReplaceQueryParameter(main_frame_url, "constrained", "0"),
- content::PAGE_TRANSITION_AUTO_TOPLEVEL);
- chrome::Navigate(&params);
-
- web_ui()->CallJavascriptFunction("inline.login.closeDialog");
-}
-
void InlineLoginHandlerImpl::CompleteLogin(const base::ListValue* args) {
content::WebContents* contents = web_ui()->GetWebContents();
const GURL& current_url = contents->GetURL();

Powered by Google App Engine
This is Rietveld 408576698