Implemented inline login dialog for Chrome OS.

chrome/browser/ui/webui/chromeos/login/inline_login_handler_chromeos.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/chromeos/login/inline_login_handler_chromeos.h"
 
 #include "chrome/browser/chromeos/login/oauth2_token_fetcher.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
+#include "chrome/browser/signin/signin_promo.h"
+#include "chrome/common/url_constants.h"
 #include "components/signin/core/browser/profile_oauth2_token_service.h"
 #include "components/signin/core/browser/signin_manager.h"
+#include "content/public/browser/storage_partition.h"
+#include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_ui.h"
+#include "google_apis/gaia/gaia_urls.h"
+#include "net/base/url_util.h"
 
 namespace chromeos {
 
 class InlineLoginHandlerChromeOS::InlineLoginUIOAuth2Delegate
     : public OAuth2TokenFetcher::Delegate {
  public:
-  explicit InlineLoginUIOAuth2Delegate(content::WebUI* web_ui)
-      : web_ui_(web_ui) {}
+  explicit InlineLoginUIOAuth2Delegate(content::WebUI* web_ui,
+                                       const std::string& account_id)
+      : web_ui_(web_ui), account_id_(account_id) {}
+
   virtual ~InlineLoginUIOAuth2Delegate() {}
 
   // OAuth2TokenFetcher::Delegate overrides:
   virtual void OnOAuth2TokensAvailable(
       const GaiaAuthConsumer::ClientOAuthResult& oauth2_tokens) OVERRIDE {
     // Closes sign-in dialog before update token service. Token service update
     // might trigger a permission dialog and if this dialog does not close,
     // a DCHECK would be triggered because attempting to activate a window
     // while there is a modal dialog.
     web_ui_->CallJavascriptFunction("inline.login.closeDialog");
 
     Profile* profile = Profile::FromWebUI(web_ui_);
     ProfileOAuth2TokenService* token_service =
         ProfileOAuth2TokenServiceFactory::GetForProfile(profile);
-    SigninManagerBase* signin_manager =
-        SigninManagerFactory::GetForProfile(profile);
-    token_service->UpdateCredentials(
-        signin_manager->GetAuthenticatedAccountId(),
-        oauth2_tokens.refresh_token);
+    token_service->UpdateCredentials(account_id_, oauth2_tokens.refresh_token);
   }
 
   virtual void OnOAuth2TokensFetchFailed() OVERRIDE {
     LOG(ERROR) << "Failed to fetch oauth2 token with inline login.";
     web_ui_->CallJavascriptFunction("inline.login.handleOAuth2TokenFailure");
   }
 
  private:
   content::WebUI* web_ui_;
+  std::string account_id_;
+
+  DISALLOW_COPY_AND_ASSIGN(InlineLoginUIOAuth2Delegate);
 };
 
 InlineLoginHandlerChromeOS::InlineLoginHandlerChromeOS() {}
 
 InlineLoginHandlerChromeOS::~InlineLoginHandlerChromeOS() {}
 
+void InlineLoginHandlerChromeOS::SetExtraInitParams(
+    base::DictionaryValue& params) {
+  const GURL& current_url = web_ui()->GetWebContents()->GetURL();
+  params.SetInteger("authMode", InlineLoginHandler::kDesktopAuthMode);

[guohui, 2014/04/29 13:33:07]

most code here is duplicated in InlineLOginHandlerImpl::SetExtraInitParams, we
should extract common logic  into InlineLoginHandler::HandleInitializeMessage.

i am not sure if you could reuse the kDesktopAuthMode without any modification,
e.g. X-Cros-Auth-Ext-Support is not set in desktop mode, and i thought it was
required for enabling saml support on cros?

[dzhioev (left Google), 2014/04/29 14:27:21]

Done. After that I was able to remove
InlineLoginHandlerChromeOS::SetExtraInitParams completely. 
As long as desktop implementation for adding accounts doesn't support SAML, I
think it is OK if Chrome OS implementation doesn't support it as well.

+
+  std::string frame_url;
+  net::GetValueForKeyInQuery(current_url, "frameUrl", &frame_url);
+  if (!frame_url.empty())
+    params.SetString("frameUrl", frame_url);
+
+  std::string is_constrained;
+  net::GetValueForKeyInQuery(current_url, "constrained", &is_constrained);
+  if (!is_constrained.empty())
+    params.SetString("constrained", is_constrained);
+
+  params.SetString(
+      "gaiaPath",
+      GaiaUrls::GetInstance()->embedded_signin_url().path().substr(1));
+  params.SetString(
+      "continueUrl",
+      signin::GetLandingURL(
+          "source", static_cast<int>(signin::SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT))
+          .spec());
+}
+
 void InlineLoginHandlerChromeOS::CompleteLogin(const base::ListValue* args) {
   Profile* profile = Profile::FromWebUI(web_ui());
 
-  oauth2_delegate_.reset(new InlineLoginUIOAuth2Delegate(web_ui()));
-  oauth2_token_fetcher_.reset(new OAuth2TokenFetcher(
-      oauth2_delegate_.get(), profile->GetRequestContext()));
-  oauth2_token_fetcher_->StartExchangeFromCookies();
+  const base::DictionaryValue* dict = NULL;
+  args->GetDictionary(0, &dict);
+
+  std::string session_index;
+  dict->GetString("sessionIndex", &session_index);
+  CHECK(!session_index.empty()) << "Session index is empty.";
+
+  std::string account_id;
+  dict->GetString("email", &account_id);
+  CHECK(!account_id.empty()) << "Account ID is empty.";
+
+  oauth2_delegate_.reset(new InlineLoginUIOAuth2Delegate(web_ui(), account_id));
+  net::URLRequestContextGetter* request_context =
+      content::BrowserContext::GetStoragePartitionForSite(
+          profile, GURL(chrome::kChromeUIChromeSigninURL))
+          ->GetURLRequestContext();
+  oauth2_token_fetcher_.reset(
+      new OAuth2TokenFetcher(oauth2_delegate_.get(), request_context));
+  oauth2_token_fetcher_->StartExchangeFromCookies(session_index);
 }
 
 } // namespace chromeos